Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage for Spree::Adjustment to 100% #5672

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Feb 28, 2024

Summary

This tests a few previously untested methods on the Spree::Adjustment model. I'm doing this because the work in #5634 removes some lines from the file, leading to a negative change in test coverage because the overall file gets smaller. By increasing coverage to 100%, a smaller file will not be punished with a larger proportion of untested lines.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

@mamhoff mamhoff requested a review from a team as a code owner February 28, 2024 11:42
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.72%. Comparing base (928781f) to head (14531c0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5672      +/-   ##
==========================================
+ Coverage   88.69%   88.72%   +0.03%     
==========================================
  Files         695      695              
  Lines       16589    16589              
==========================================
+ Hits        14713    14718       +5     
+ Misses       1876     1871       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😊

@tvdeyen tvdeyen merged commit ddabeef into solidusio:main Feb 28, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants