Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push spec coverage for Spree::Order to 100% #5673

Merged
merged 18 commits into from
Feb 29, 2024

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Feb 28, 2024

Summary

This adds specs for the Spree::Order model so the coverage for that file goes up to 100%. It also covers a case where Spree::Promotion is called from within the rest of the system, so adding specs here makes sure this gets picked up in #5634.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

@mamhoff mamhoff requested a review from a team as a code owner February 28, 2024 14:08
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.82%. Comparing base (928781f) to head (36d1c02).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5673      +/-   ##
==========================================
+ Coverage   88.69%   88.82%   +0.13%     
==========================================
  Files         695      695              
  Lines       16589    16589              
==========================================
+ Hits        14713    14736      +23     
+ Misses       1876     1853      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit 49e3da4 into solidusio:main Feb 29, 2024
14 checks passed
@mamhoff mamhoff deleted the order-coverage branch February 29, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants