-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push spec coverage for Spree::Order to 100% #5673
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm wondering whether this method should be deprecated as not many real-world payment systems work with credit cards any longer.
There was one branch missing here.
github-actions
bot
added
the
changelog:solidus_core
Changes to the solidus_core gem
label
Feb 28, 2024
mamhoff
force-pushed
the
order-coverage
branch
from
February 28, 2024 14:13
439fc91
to
208717f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5673 +/- ##
==========================================
+ Coverage 88.69% 88.82% +0.13%
==========================================
Files 695 695
Lines 16589 16589
==========================================
+ Hits 14713 14736 +23
+ Misses 1876 1853 -23 ☔ View full report in Codecov by Sentry. |
jarednorman
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds specs for the Spree::Order model so the coverage for that file goes up to 100%. It also covers a case where Spree::Promotion is called from within the rest of the system, so adding specs here makes sure this gets picked up in #5634.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: