Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Node 20 in docker-compose.yml #5737

Merged
merged 1 commit into from
May 3, 2024

Conversation

nvandoorn
Copy link
Contributor

Summary

Node version 14 is quite out of date, but most notably there is a 60 second penalty imposed by NodeSource as a way of warning users to upgrade.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@nvandoorn nvandoorn requested a review from a team as a code owner May 1, 2024 22:19
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label May 1, 2024
docker-compose.yml Outdated Show resolved Hide resolved
@nvandoorn nvandoorn requested a review from tvdeyen May 3, 2024 04:36
@nvandoorn nvandoorn force-pushed the update-node-in-docker-compose branch from 241a1ef to edecb3e Compare May 3, 2024 04:40
Node version 14 is quite out of date, but most notably there is a 60
second penalty imposed by NodeSource as a way of warning users to
upgrade.

Co-authored-by: An Stewart <[email protected]>
@nvandoorn nvandoorn force-pushed the update-node-in-docker-compose branch from edecb3e to d12907d Compare May 3, 2024 08:42
@nvandoorn nvandoorn changed the title Update to Node 18 in docker-compose.yml Update to Node 20 in docker-compose.yml May 3, 2024
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏🏻

@tvdeyen tvdeyen merged commit a1551e7 into solidusio:main May 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:repository Changes to the repository not within any gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants