Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.3] fix(StoreCredit): Add display_number method #5745

Merged
merged 1 commit into from
May 8, 2024

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented May 8, 2024

Backport

This will backport the following commits from main to v4.3:

Questions ?

Please refer to the Backport tool documentation

@github-actions github-actions bot requested a review from a team as a code owner May 8, 2024 10:38
@github-actions github-actions bot added changelog:solidus_core Changes to the solidus_core gem type:bug Error, flaw or fault labels May 8, 2024
display_number is used by many partials and templates
displaying the payment source identifier to users
or admins.

StoreCredit was missing this metho, leading to errors
if a store credit is used as payment source.

(cherry picked from commit 89aaf70)
@tvdeyen tvdeyen merged commit de92fa4 into v4.3 May 8, 2024
11 checks passed
@tvdeyen tvdeyen deleted the backport/v4.3/pr-5741 branch May 8, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem type:bug Error, flaw or fault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant