Deprecated Configurable Class: Allow class methods #5762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
tvdeyen
approved these changes
May 28, 2024
The previous implementation of `Spree::DeprecatedConfigurableClass` could deal with instance methods, but not with class methods. This creates a thing that issues deprecation warnings on instance methods and class methods.
mamhoff
force-pushed
the
add-warnings-on-deprecated-class-methods
branch
from
de2aa00
to
b2ebf63
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5762 +/- ##
==========================================
- Coverage 88.91% 88.91% -0.01%
==========================================
Files 711 711
Lines 16879 16885 +6
==========================================
+ Hits 15008 15013 +5
- Misses 1871 1872 +1 ☔ View full report in Codecov by Sentry. |
jarednorman
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The previous implementation of
Spree::DeprecatedConfigurableClasscould deal with instance methods, but not with class methods. This creates a thing that issues deprecation warnings on instance methods and class methods.