Rename PromotionConfiguration to LegacyPromotionConfiguration #5769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5769 +/- ##
==========================================
- Coverage 88.91% 88.91% -0.01%
==========================================
Files 711 711
Lines 16885 16884 -1
==========================================
- Hits 15013 15012 -1
Misses 1872 1872 ☔ View full report in Codecov by Sentry. |
adammathys
approved these changes
May 31, 2024
mamhoff
force-pushed
the
rename-legacy-promotion-configuration
branch
2 times, most recently
from
1dfa0b8
to
a905687
Compare
mamhoff
force-pushed
the
rename-legacy-promotion-configuration
branch
2 times, most recently
from
6ee92e1
to
029804b
Compare
Earlier in the extraction process, I've defined a configuration object for the current promotion system and called it `Spree::Core::PromotionConfiguration`. However, it is much more aptly named `SolidusLegacyPromotions::Configuration`, as it will be moved into that gem shortly. This way it's also clear when we move to the `Spree::Core::NullPromotionConfiguration` what we are changing.
mamhoff
force-pushed
the
rename-legacy-promotion-configuration
branch
from
029804b
to
7acf34b
Compare
github-actions
bot
added
the
changelog:solidus_core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Earlier in the extraction process, I've defined a configuration object for the current promotion system and called it
Spree::Core::PromotionConfiguration. However, it is much more aptly namedSolidusLegacyPromotions::Configuration, as it will be moved into that gem shortly. This way it's also clear when we move to theSpree::Core::NullPromotionConfigurationwhat we are changing.