Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Psych 5 #5788

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Allow Psych 5 #5788

merged 1 commit into from
Jun 14, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jun 13, 2024

Ruby 3.3 has psych 5 as default gem and we get a Bundler error about psych 5 already been activated although solidus does not allow it.

@tvdeyen tvdeyen requested a review from a team as a code owner June 13, 2024 08:56
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Jun 13, 2024
@tvdeyen tvdeyen added the backport-v4.3 Backport this pull-request to v4.3 label Jun 13, 2024
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (e6063b2) to head (d03262b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5788   +/-   ##
=======================================
  Coverage   88.92%   88.92%           
=======================================
  Files         718      718           
  Lines       16939    16939           
=======================================
  Hits        15063    15063           
  Misses       1876     1876           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.circleci/config.yml Outdated Show resolved Hide resolved
@tvdeyen tvdeyen mentioned this pull request Jun 14, 2024
Ruby 3.3 has psych 5 as default gem and we get a Bundler error
about psych 5 already been activated although solidus does not allow
it.
@tvdeyen tvdeyen merged commit 8b77a17 into solidusio:main Jun 14, 2024
14 checks passed
@tvdeyen tvdeyen deleted the psych-5 branch June 14, 2024 17:54
@github-actions github-actions bot mentioned this pull request Jun 14, 2024
Copy link

💚 All backports created successfully

Status Branch Result
v4.3

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.3 Backport this pull-request to v4.3 changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants