Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin installer fixes #5880

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Admin installer fixes #5880

merged 1 commit into from
Oct 18, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Oct 18, 2024

Run bundle install after adding lookbook

The following mount task will fail with a bundler error if we do not
also install the lookbook gem. Just adding it to the gemgroup
won't run bundle install for us.

The following mount task will fail with a bundler error if we do not
also install the lookbook gem. Just adding it to the gemgroup
won't run bundle install for us.
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.32%. Comparing base (41cb5d3) to head (9db13eb).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...erators/solidus_admin/install/install_generator.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5880      +/-   ##
==========================================
- Coverage   89.33%   89.32%   -0.01%     
==========================================
  Files         759      759              
  Lines       17678    17679       +1     
==========================================
  Hits        15792    15792              
- Misses       1886     1887       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@forkata forkata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tvdeyen!

@tvdeyen tvdeyen merged commit b7c7bd5 into main Oct 18, 2024
12 of 14 checks passed
@tvdeyen tvdeyen deleted the admin-installer-fixes branch October 18, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants