Fix test suite by running Puma's master branch
#5886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current release is incompatible with Capybara when also using Rackup 1.0.1, causing all feature specs to fail. The fix has been merged into puma's `master` branch, so we can temporarily run that in CI.
github-actions
bot
added
the
changelog:repository
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5886 +/- ##
=======================================
Coverage 89.32% 89.32%
=======================================
Files 759 759
Lines 17682 17682
=======================================
Hits 15795 15795
Misses 1887 1887 ☔ View full report in Codecov by Sentry. |
kennyadsl
approved these changes
Oct 25, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current release is incompatible with Capybara when also using Rackup 1.0.1, causing all feature specs to fail. The fix has been merged into puma's
masterbranch, so we can temporarily run that in CI.See puma/puma#3532 for more context.