don't attempt to read v1 DestinationRules when istio is too old #10459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues linked to changelog: |
npolshakova
approved these changes
Dec 10, 2024
yuval-k
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to the way Istio's
NewDelayedInformerworks, we will always try to get thev1struct. This causes failures internally when we try to force it to give usv1beta1, preventing us from running with old Istio versions. #10424 attempts to fix this, but this PR is safer in the short-term to just disable reading DRs all together when the v1 CRD isn't present.Code changes
Testing steps
BOT NOTES:
resolves https://github.com/solo-io/solo-projects/issues/7400