listener options merge what translator generates #10578
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenctl
force-pushed
the
merge-listener-opts
branch
from
d2beba6 to
b563ba7
Compare
|
Issues linked to changelog: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A translator may generate a Listener with ListenerOptions (it's currently the internal IR).
A user listener opts should not automatically clear unrelated items in ListenerOptions.
This would also apply if another plugin used ListenerOptions.
API changes
ListenerOptions will now act as an overlay to system ones (if the system ones exist).
Code changes
Use proto merge when existing options are on the listener.
Testing steps
Added base options in the unit tests
Notes for reviewers
Open to manually implementing merge logic instead of proto merge
BOT NOTES:
resolves https://github.com/solo-io/solo-projects/issues/7300