Reduce nooneway test failures #10599
Merged
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/kick-ci |
|
Issues linked to changelog: |
ryanrolds
changed the title
|
Visit the preview URL for this PR (updated for commit 89da532): https://gloo-edge--pr10599-rolds-improve-noonew-e49sfiba.web.app (expires Tue, 18 Feb 2025 16:24:23 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
andy-fong
approved these changes
Feb 11, 2025
sam-heilbron
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Was able to reproduce locally. After looking at the logs and things, it appears things were getting to a working state but just not fast enough for the test. Adjusting the timeout. I was able to confirm that I no longer saw the test fail locally with 2m.
Checklist: