Add RemoveMatches in snapshot template #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues linked to changelog: |
davidjumani
commented
Sep 5, 2024
| continue // skip syncing this syncer | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Copied over from
| for { | ||
| select { | ||
| case snapshot, ok := <-watch: | ||
| if !ok { | ||
| return | ||
| } | ||
|
|
||
| if syncDecider, isDecider := el.syncer.(TestingSyncDecider); isDecider { |
There was a problem hiding this comment.
When this is running, how should I expect to debug this behavior? Should we have metrics or logs emitted when a sync is not necessary?
There was a problem hiding this comment.
Yes, the Syncer that implements SyncDecider can have metrics to track this
There was a problem hiding this comment.
Is that something that we need to implement here, or in Gloo we can define that SyncDecider?
davidjumani
changed the title
jbohanon
approved these changes
Sep 17, 2024
| for { | ||
| select { | ||
| case snapshot, ok := <-watch: | ||
| if !ok { | ||
| return | ||
| } | ||
|
|
||
| if syncDecider, isDecider := el.syncer.({{ .GoName }}SyncDecider); isDecider { | ||
| if shouldSync := syncDecider.ShouldSync(previousSnapshot, snapshot); !shouldSync { |
There was a problem hiding this comment.
nit:
Suggested change
| if shouldSync := syncDecider.ShouldSync(previousSnapshot, snapshot); !shouldSync { | |
| if !syncDecider.ShouldSync(previousSnapshot, snapshot) { |
| continue // skip syncing this syncer | ||
| } | ||
| } else if syncDeciderWithContext, isDecider := el.syncer.({{ .GoName }}SyncDeciderWithContext); isDecider { | ||
| if shouldSync := syncDeciderWithContext.ShouldSync(opts.Ctx, previousSnapshot, snapshot); !shouldSync { |
There was a problem hiding this comment.
nit:
Suggested change
| if shouldSync := syncDeciderWithContext.ShouldSync(opts.Ctx, previousSnapshot, snapshot); !shouldSync { | |
| if !syncDeciderWithContext.ShouldSync(opts.Ctx, previousSnapshot, snapshot) { |
sam-heilbron
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RemoveMatchesmethod insnapshot_template.gothat removes all resources that match the given crietria.SyncDeciderto determine if a sync is necessary.