[SFT-1608]: Write integration for Form Monitor #1686
+2,649
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feat/SFT-1608-form-monitor
seandelaney
reviewed
Dec 16, 2024
| useSidebarSelect(5); | ||
|
|
||
| const { data: forms, isFetching: isFetchingForms } = useQueryFormsWithStats(); | ||
| const { data: formIds, isFetching: isFetchingFormids } = useFMForms(); |
There was a problem hiding this comment.
isFetchingFormids --> isFetchingFormIds
There was a problem hiding this comment.
Also not liking the use of FM instead of FormMonitor throughout the API
There was a problem hiding this comment.
Good pointers, I'll change them
seandelaney
reviewed
Dec 16, 2024
packages/plugin/src/Integrations/Other/FormMonitor/FormMonitor.php
Outdated
Show resolved
Hide resolved
seandelaney
previously approved these changes
Dec 16, 2024
…feat/SFT-1608-form-monitor # Conflicts: # packages/plugin/src/Resources/js/client/client.js
…feat/SFT-1608-form-monitor
…feat/SFT-1608-form-monitor
…into feat/SFT-1608-form-monitor # Conflicts: # packages/plugin/src/Models/Pro/ExportProfileModel.php # packages/plugin/src/Resources/js/client/client.js
…feat/SFT-1608-form-monitor # Conflicts: # composer.json # packages/plugin/src/Resources/js/client/client.js
…feat/SFT-1608-form-monitor # Conflicts: # packages/plugin/src/Resources/js/client/client.js
…feat/SFT-1608-form-monitor # Conflicts: # packages/plugin/src/Resources/js/client/client.js
thejahid
force-pushed
the
feat/SFT-1608-form-monitor
branch
from
86d743e to
eed99e5
Compare
…feat/SFT-1608-form-monitor
…feat/SFT-1608-form-monitor
…feat/SFT-1608-form-monitor # Conflicts: # packages/plugin/src/Resources/js/client/client.js
thejahid
force-pushed
the
feat/SFT-1608-form-monitor
branch
from
2647942 to
512f566
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket Number
SFT-1608
Description
Integrating Form Monitor into Freeform