Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename test_view.py to test_pilot.py #448

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

yungyuc
Copy link
Member

@yungyuc yungyuc commented Dec 26, 2024

No description provided.

@yungyuc yungyuc added test testing and continuous integration refactor Change code without changing tests pilot GUI and visualization labels Dec 26, 2024
@yungyuc yungyuc self-assigned this Dec 26, 2024
@yungyuc yungyuc requested a review from j8xixo12 December 26, 2024 14:58
Copy link
Collaborator

@j8xixo12 j8xixo12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the profiler unit test failed again...

Copy link
Collaborator

@tigercosmos tigercosmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yungyuc
Copy link
Member Author

yungyuc commented Dec 26, 2024

LGTM, but the profiler unit test failed again...

It should be false alarm and I will rerun to confirm. @ThreeMonth03 we need to fix the unstable profiler tests. We are not using a right way for timing.

@yungyuc yungyuc merged commit 35650f4 into solvcon:master Dec 26, 2024
12 checks passed
@yungyuc yungyuc deleted the refactor/rename-test-pilot branch December 26, 2024 22:40
@yungyuc yungyuc linked an issue Dec 26, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pilot GUI and visualization refactor Change code without changing tests test testing and continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the "viewer" to use an official name
3 participants