Enhance: Add a file dialog for loading Gmsh file #449
Conversation
yungyuc
added
pilot
| @@ -153,7 +153,7 @@ jobs: | |||
| - name: dependency by pip | |||
| run: | | |||
| sudo pip3 install setuptools | |||
| sudo pip3 install numpy pytest flake8 jsonschema | |||
| sudo pip3 install numpy matplotlib pytest flake8 jsonschema | |||
There was a problem hiding this comment.
The added matplotlib is for followup refactor. It's included with the Qt upgrade so that the other branch of mine does not need to duplicate it.
| host: 'windows' | ||
| target: 'desktop' | ||
| arch: 'win64_msvc2019_64' | ||
| arch: 'win64_msvc2022_64' |
There was a problem hiding this comment.
Reminded by @terrychan999 .
| @@ -39,13 +39,15 @@ | |||
| enable = False | |||
| try: | |||
| from _modmesh import pilot as _vimpl # noqa: F401 | |||
|
|
|||
| @@ -71,6 +73,9 @@ def _load(): | |||
| del _load | |||
|
|
|||
|
|
|||
| _holder = {} | |||
There was a problem hiding this comment.
A temporary hack to keep object lifetime.
| tip="Create new file", | ||
| funcname=lambda: print("This is only a demo: Create new file!"), | ||
| ) | ||
| _holder['gmsh_dialog'] = _mesh.GmshFileDialog(mgr=wm) |
There was a problem hiding this comment.
Add a file dialog manager.
| @staticmethod | ||
| def _get_initial_path(): | ||
| """ | ||
| Search for `tests/data/rectangle.msh` and return the directory holding |
There was a problem hiding this comment.
Look for the sample data directory.
| @@ -68,17 +68,19 @@ class PilotCameraTB: | |||
|
|
|||
| @classmethod | |||
| def setUpClass(cls): | |||
| widget = pilot.RManager.instance.setUp().add3DWidget() | |||
| if modmesh.HAS_PILOT: | |||
There was a problem hiding this comment.
Make pilot testing skip more robust.
|
@terrychan999 @j8xixo12 I merged the enhancement. If there are issues I will fix in a followup PR. I continue to restructure the mesh GUI code. It broke windows CI run and I am still troubleshooting. |
Also upgrade Windows Qt/PySide6 to 6.8.1 with win64_msvc2022_64.