Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Javier Spagnoletti <[email protected]>
  • Loading branch information
jordisala1991 and phansys authored Apr 24, 2021
1 parent f75bc3b commit f293e41
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion UPGRADE-4.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Frontend dependencies are handled with NPM. Bower is not used anymore.
A lot of assets that were previously public are handled with NPM and placed in a private `node_modules/` directory.
From these dependencies, only the necessary files are exposed publicly through Webpack Encore.

The `jquery-ui` dependency was full included before, but now we only include the sortable widget (JavaScript and CSS), the rest of this dependency is not exposed. If you are adding more JavaScript or CSS using another widget of `jquery-ui` please include it yourself.
The `jquery-ui` dependency was fully included before, but now we only include the sortable widget (JavaScript and CSS), the rest of this dependency is not exposed. If you are adding more JavaScript or CSS using another widget of `jquery-ui` please include it yourself.

Please check the `src/Resources/public/dist` and the documentation to see the used CSS, JavaScript, images and fonts.

Expand Down
2 changes: 1 addition & 1 deletion assets/js/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import 'jquery-form';
// Boostrap 3 JavaScript for the x-editable library
import 'x-editable/dist/bootstrap3-editable/js/bootstrap-editable';

// Full version of the select2, needed because SonataAdmin needs
// Full version of Select2, needed because SonataAdmin needs
// compat dropdownCss and it only comes on the full version
import 'select2/dist/js/select2.full';
import 'admin-lte';
Expand Down
2 changes: 1 addition & 1 deletion assets/scss/app.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
@import "~font-awesome/scss/font-awesome";

// Basic AdminLTE styles without any plugins,
// because they conflict with select2 v4
// because they conflict with Select2 v4
@import "~admin-lte/dist/css/alt/AdminLTE-without-plugins.css";
@import "~icheck/skins/square/blue.css";

Expand Down

0 comments on commit f293e41

Please sign in to comment.