Process NEXT_MAJOR hints for "Add pre batch action event" #7620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
previously approved these changes
Nov 26, 2021
|
You should add this to the upgrade 5.0 file instead of the changelog. Maybe the file is not even created, take a look at how we did for 4.0 |
A pre batch action event was added to 4.x through sonata-project#7579. This processes all the NEXT_MAJOR comments for 5.x for this specific feature
7ochem
force-pushed
the
process-next-major-hints-for-pre-batch-action-event
branch
from
62abb28 to
f1390f8
Compare
I've added the UPGRADE-5.0 guide in #7621 and appended a section about this change in this PR. I think the changelog should also contain a line about this change because it actually introduces the new/real method instead of just having an annotation. |
VincentLanglet
approved these changes
Nov 26, 2021
core23
approved these changes
Nov 26, 2021
7ochem
deleted the
process-next-major-hints-for-pre-batch-action-event
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
A pre batch action event was added to 4.x through #7579. This PR processes all the NEXT_MAJOR comments for 5.x for this specific feature.
I am targeting this branch, because this has been implemented in a backwards compatible manner in 4.x and has been forward merged into 5.x. This PR changes that backwards compatibility into a BC break: Introducing the new
preBatchAction()method in the AdminExtensionInterface.Changelog
To do