Use h5py for output data writing and consolidation to reduce memory footprint #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should also help with songlab-cal/tape#8 |
|
Should we merge this? I don't think the |
|
It depends on |
|
Closing since both this and rinokeras are in basic maintenance mode now, so no major changes will be made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on CannyLab/rinokeras#12, the data consolidation step will read the entire output dataset into memory (which will crash for relatively small datasets if we include all encoder outputs, especially for the LSTM).
hdf5 allows us to iteratively write, and avoid the memory overhead of pickle
Upon reflection, some documentation update should probably be done as well, because I think we reference pickle a few time