Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Arista]: Change the TH5 Yaml settings to use 8 UC and 4 MC queues #19912

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Pterosaur
Copy link
Contributor

@Pterosaur Pterosaur commented Aug 15, 2024

Why I did it

The current YAML file for TH5 should be used only with 8 UC and 4 MC queues.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Change the TH5 Yaml settings to use 8 UC and 4 MC queues

How to verify it

Local ixia test is passing in lab.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@lguohan
Copy link
Collaborator

lguohan commented Aug 15, 2024

@kperumalbfn , what is this PR about? what is current # of UC and # MC queue configured?

@Pterosaur
Copy link
Contributor Author

We discussed this internally, this PR is not required as these changes can cause flexcounter issue.

@Pterosaur Pterosaur closed this Oct 20, 2024
@Pterosaur Pterosaur reopened this Oct 29, 2024
@Pterosaur Pterosaur self-assigned this Oct 29, 2024
@Pterosaur Pterosaur marked this pull request as ready for review October 29, 2024 14:09
@Pterosaur Pterosaur removed their assignment Oct 29, 2024
@@ -2622,7 +2622,7 @@ device:
TM_PORT_UC_Q_TO_SERVICE_POOL:
?
PORT_ID: [[1,8], [11,18], [21,29], [33,40], [43,51], [55,62], [65,73], [76,84], [87,95], [99,106], [109,117], [121,128], [131,139], [143,150], [153,161], [165,172], [175,183], [187,194], [197,205], [209,216], [219,227], [231,238], [241,249], [253,260], [263,271], [274,282], [285,293], [297,304], [307,315], [319,326], [329,337], [341,348], 351]
TM_UC_Q_ID: [0,1,2,5,6,8,9]
TM_UC_Q_ID: [0,1,2,5,6]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when searching the BCM file, I am still seeing some UC Q settings on queue 8 and 9. they are removed in the first commit, but somehow removed in the second one:

E.g.:

                PORT_ID: [[1,8], [11,18], [22,29], [33,40], [44,51], [55,62], [66,73], [77,84], [88,95], [99,106], [110,117], [121,128], [132,139], [143,150], [154,161], [165,172]]
                TM_UC_Q_ID: [8,9]
            :
                MIN_GUARANTEE_CELLS: 0
                SHARED_LIMITS: 1
                DYNAMIC_SHARED_LIMITS: 1
                SHARED_LIMIT_CELLS_STATIC: 0
                SHARED_LIMIT_DYNAMIC: ALPHA_1
                DYNAMIC_GROUP: MID_PRI_GROUP
                RESUME_OFFSET_CELLS: 2
                COLOR_SPECIFIC_LIMITS: 0
                COLOR_SPECIFIC_DYNAMIC_LIMITS: 0
                YELLOW_LIMIT_CELLS_STATIC: 0
                YELLOW_LIMIT_DYNAMIC: PERCENTAGE_750
                RED_LIMIT_CELLS_STATIC: 0
                RED_LIMIT_DYNAMIC: PERCENTAGE_625
            ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to remove this block as well -

PORT_ID: [[176,183], [187,194], [198,205], [209,216], [220,227], [231,238], [242,249], [253,260], [264,271], [275,282], [286,293], [297,304], [308,315], [319,326], [330,337], [341,348]]
TM_UC_Q_ID: [8,9]
:
MIN_GUARANTEE_CELLS: 0
SHARED_LIMITS: 1
DYNAMIC_SHARED_LIMITS: 1
SHARED_LIMIT_CELLS_STATIC: 0
SHARED_LIMIT_DYNAMIC: ALPHA_1
DYNAMIC_GROUP: MID_PRI_GROUP
RESUME_OFFSET_CELLS: 2
COLOR_SPECIFIC_LIMITS: 0
COLOR_SPECIFIC_DYNAMIC_LIMITS: 0
YELLOW_LIMIT_CELLS_STATIC: 0
YELLOW_LIMIT_DYNAMIC: PERCENTAGE_750
RED_LIMIT_CELLS_STATIC: 0
RED_LIMIT_DYNAMIC: PERCENTAGE_625

Signed-off-by: Ze Gan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants