[Arista]: Change the TH5 Yaml settings to use 8 UC and 4 MC queues #19912
+6
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ses 8 UC queues. Signed-off-by: Ze Gan <[email protected]>
Pterosaur
requested review from
kperumalbfn and
r12f
and removed request for
kperumalbfn
|
@kperumalbfn , what is this PR about? what is current # of UC and # MC queue configured? |
|
We discussed this internally, this PR is not required as these changes can cause flexcounter issue. |
Signed-off-by: Ze Gan <[email protected]>
r12f
reviewed
Oct 29, 2024
| @@ -2622,7 +2622,7 @@ device: | |||
| TM_PORT_UC_Q_TO_SERVICE_POOL: | |||
| ? | |||
| PORT_ID: [[1,8], [11,18], [21,29], [33,40], [43,51], [55,62], [65,73], [76,84], [87,95], [99,106], [109,117], [121,128], [131,139], [143,150], [153,161], [165,172], [175,183], [187,194], [197,205], [209,216], [219,227], [231,238], [241,249], [253,260], [263,271], [274,282], [285,293], [297,304], [307,315], [319,326], [329,337], [341,348], 351] | |||
| TM_UC_Q_ID: [0,1,2,5,6,8,9] | |||
| TM_UC_Q_ID: [0,1,2,5,6] | |||
There was a problem hiding this comment.
when searching the BCM file, I am still seeing some UC Q settings on queue 8 and 9. they are removed in the first commit, but somehow removed in the second one:
E.g.:
PORT_ID: [[1,8], [11,18], [22,29], [33,40], [44,51], [55,62], [66,73], [77,84], [88,95], [99,106], [110,117], [121,128], [132,139], [143,150], [154,161], [165,172]]
TM_UC_Q_ID: [8,9]
:
MIN_GUARANTEE_CELLS: 0
SHARED_LIMITS: 1
DYNAMIC_SHARED_LIMITS: 1
SHARED_LIMIT_CELLS_STATIC: 0
SHARED_LIMIT_DYNAMIC: ALPHA_1
DYNAMIC_GROUP: MID_PRI_GROUP
RESUME_OFFSET_CELLS: 2
COLOR_SPECIFIC_LIMITS: 0
COLOR_SPECIFIC_DYNAMIC_LIMITS: 0
YELLOW_LIMIT_CELLS_STATIC: 0
YELLOW_LIMIT_DYNAMIC: PERCENTAGE_750
RED_LIMIT_CELLS_STATIC: 0
RED_LIMIT_DYNAMIC: PERCENTAGE_625
?
There was a problem hiding this comment.
Good to remove this block as well -
Signed-off-by: Ze Gan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
The current YAML file for TH5 should be used only with 8 UC and 4 MC queues.
Work item tracking
How I did it
Change the TH5 Yaml settings to use 8 UC and 4 MC queues
How to verify it
Local ixia test is passing in lab.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)