-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for SNMP Tests Flakiness #14945
Fixes for SNMP Tests Flakiness #14945
Conversation
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
@abdosi @SuvarnaMeenakshi @yejianquan - Can you help review and merge this PR |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@agadia-cisco @vperumal , added comments, thanks |
@agadia-cisco |
Both the failures are not related to my change & were seen before my changes too.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of PR Summary: The PR contains changes to snmp_helpers.py which checks whether snmp-subagent process is up or not before proceeding in the test. Accordingly all the snmp tests were updated to accommodate the change. This fixes the SNMP tests failures due to information not gathered in get_snmp_facts. Approach What is the motivation for this PR? It has been observed that without snmp-subagent being up, SNMP tests proceeds to execution causing TC failures because snmp_facts isn't able to capture the device information. How did you do it? Check was added in snmp_helpers ensuring that snmp-subagent is up before calling snmp_facts. All TCs were updated with the change. How did you verify/test it? Had run the changes on 202405 image installed in T0 device & tests passed. co-authorized by: [email protected]
Cherry-pick PR to 202405: #15269 |
Description of PR
Summary: The PR contains changes to
snmp_helpers.py
which checks whethersnmp-subagent
process is up or not before proceeding in the test. Accordingly all thesnmp
tests were updated to accommodate the change. This fixes the SNMP tests failures due to information not gathered inget_snmp_facts
.Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
It has been observed that without
snmp-subagent
being up, SNMP tests proceeds to execution causing TC failures becausesnmp_facts
isn't able to capture the device information.How did you do it?
Check was added in
snmp_helpers
ensuring thatsnmp-subagent
is up before callingsnmp_facts
. All TCs were updated with the change.How did you verify/test it?
Had run the changes on
202405
image installed inT0
device & tests passed.