Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-asic fixes for lldp/test_lldp_syncd.py #15258

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arista-nwolfe
Copy link
Contributor

Description of PR

Various multi-asic fixes in lldp/test_lldp_syncd.py

  • Fix helper functions db_instance, get_lldp_entry_keys, get_lldp_entry_content, get_lldpctl_output to query both namespaces

test_lldp_entry_table_after_flap

  • Ignore routeCheck log errors as this test flaps ports and churns routes ignore_expected_loganalyzer_exceptions
  • Don't skip the test if it finds eth0 port, just continue
  • Add namespace to config interface commands
  • Increase delay from 5s to 10s as verify_lldp_entry was seeing the stale LLDP_ENTRY from before link flap and returning True

test_lldp_entry_table_after_lldp_restart

  • Query the per-namespace lldp docker when available

test_lldp_entry_table_after_reboot

  • wait until check_intf_up_ports=True when rebooting, otherwise the LLDP_ENTRY may flap when the ports come up

Summary:
Fixes #15256

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/lldp/test_lldp_syncd.py:19:1: E302 expected 2 blank lines, found 1
tests/lldp/test_lldp_syncd.py:31:1: E302 expected 2 blank lines, found 1
tests/lldp/test_lldp_syncd.py:50:1: E302 expected 2 blank lines, found 1
tests/lldp/test_lldp_syncd.py:57:1: E302 expected 2 blank lines, found 1

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[202405][MultiAsic]: test_lldp_syncd fails on multi-asic systems
2 participants