solving out of boundaries vulnerability in fpmlink.cpp #3456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
reviewed
Jan 8, 2025
fpmsyncd/fpmlink.cpp
Outdated
| @@ -208,7 +208,14 @@ uint64_t FpmLink::readData() | |||
| size_t start = 0, left; | |||
| ssize_t read; | |||
|
|
|||
| read = ::read(m_connection_socket, m_messageBuffer + m_pos, m_bufSize - m_pos); | |||
| try | |||
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dgsudharsan
requested changes
Feb 6, 2025
| @@ -208,7 +208,14 @@ uint64_t FpmLink::readData() | |||
| size_t start = 0, left; | |||
| ssize_t read; | |||
|
|
|||
| try | |||
| { | |||
There was a problem hiding this comment.
Can you please correct the indentation?
| @@ -1877,8 +1877,14 @@ uint64_t MclagLink::readData() | |||
| size_t start = 0, left = 0; | |||
| ssize_t read = 0; | |||
| char * msg = NULL; | |||
|
|
|||
| try{ | |||
There was a problem hiding this comment.
Please try to have braces in newline.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
i added try and catch in line 211
Why I did it
to solve vulnerability as it is adding m_messageBuffer to m_pos without ensuring it is more than the m_bufSize - m_pos
How I verified it
by using checkmarx as it was marked high severity risk at the beginning and then it is solved after the edits