-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sfputil CLI failure for multi-asic platforms #3168
Fix sfputil CLI failure for multi-asic platforms #3168
Conversation
@prgeor @abdosi @SuvarnaMeenakshi @bmridul |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@longhuan-cisco please test this on NON-multi asic platform |
@prgeor Verified on non-multi-asic platforms also:
|
/azp run Azure.sonic-utilities |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run Azure.sonic-utilities |
Azure Pipelines successfully started running 1 pipeline(s). |
@longhuan-cisco please check the code coverage |
79cbbca
@prgeor addressed it. |
* Fix sfputil invalid namesapce error * Add test case for loading port configuration * Improve cov
* Fix sfputil invalid namesapce error * Add test case for loading port configuration * Improve cov
What I did
This PR is to fix issue #3167
Basically sfputil Cli became broken on multi-asic platforms after introduction of sonic-net/sonic-buildimage#10960 which removed the initialization of global DB config from portconfig.py (library side) and expects application to do it, but here application side (sfputil) was not updated accordingly.
How I did it
Add load_db_config call to sfputil for initialization
How to verify it
Before fix:
After fix:
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)