WIP: Helix themes support #151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the #150, I tried to taclke the implementation of Helix editor themes for the light and dark variant for onehalf.
The Helix theme implementation documentation can be found on their official docs.
Given that, the themes still need some visual tweaks, specially the light theme where some elements are invisible because of the white backgrounf color.
I just "imported" the default theme of Helix as a base theme to fill the missing gaps I can't determine which color of the pallete I should use.
So I would like to ask for help of official maintainers as I don't have somuch experience in implementing themes.
Here are some screenshots on tha code snippet written in
Elixir: