allow branches #34
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,17 @@ | ||
| module github.com/sosedoff/gitkit | ||
|
|
||
| go 1.19 | ||
|
|
||
| require ( | ||
| github.com/gofrs/uuid v4.0.0+incompatible | ||
| github.com/stretchr/testify v1.7.0 | ||
| golang.org/x/crypto v0.0.0-20210513164829-c07d793c2f9a | ||
| golang.org/x/exp v0.0.0-20230203172020-98cc5a0785f9 | ||
| ) | ||
|
|
||
| require ( | ||
| github.com/davecgh/go-spew v1.1.1 // indirect | ||
| github.com/pmezard/go-difflib v1.0.0 // indirect | ||
| golang.org/x/sys v0.1.0 // indirect | ||
| gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c // indirect | ||
| ) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| package gitkit_test | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "testing" | ||
|
|
||
| "github.com/sosedoff/gitkit" | ||
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| type gitReceiveMock struct { | ||
| name string | ||
| masterOnly bool | ||
| allowedBranches []string | ||
| ref string | ||
| err error | ||
| } | ||
|
|
||
| func TestMasterOnly(t *testing.T) { | ||
| testCases := []gitReceiveMock{ | ||
| { | ||
| name: "push to master, no error", | ||
| masterOnly: true, | ||
| ref: "refs/heads/master", | ||
| err: nil, | ||
| }, | ||
| { | ||
| name: "push to a branch, should trigger error", | ||
| masterOnly: true, | ||
| ref: "refs/heads/branch", | ||
| err: fmt.Errorf("cannot push branch, allowed branches: refs/heads/master"), | ||
| }, | ||
| } | ||
|
|
||
| for _, tc := range testCases { | ||
| t.Run(tc.name, func(t *testing.T) { | ||
| r := &gitkit.Receiver{ | ||
| MasterOnly: tc.masterOnly, | ||
| } | ||
|
|
||
| err := r.CheckAllowedBranch(&gitkit.HookInfo{ | ||
| Ref: tc.ref, | ||
| }) | ||
|
|
||
| assert.Equal(t, tc.err, err) | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| func TestAllowedBranches(t *testing.T) { | ||
| testCases := []gitReceiveMock{ | ||
| { | ||
| name: "push to master, no error", | ||
| allowedBranches: []string{"refs/heads/master"}, | ||
| ref: "refs/heads/master", | ||
| err: nil, | ||
| }, | ||
| { | ||
| name: "push to a branch, should trigger error", | ||
| allowedBranches: []string{"refs/heads/master"}, | ||
| ref: "refs/heads/some-branch", | ||
| err: fmt.Errorf("cannot push branch, allowed branches: refs/heads/master"), | ||
| }, | ||
| { | ||
| name: "push to another-branch", | ||
| allowedBranches: []string{"refs/heads/another-branch"}, | ||
| ref: "refs/heads/another-branch", | ||
| err: nil, | ||
| }, | ||
| { | ||
| name: "push to main and only allow main", | ||
| allowedBranches: []string{"refs/heads/main"}, | ||
| ref: "refs/heads/main", | ||
| err: nil, | ||
| }, | ||
| } | ||
|
|
||
| for _, tc := range testCases { | ||
| t.Run(tc.name, func(t *testing.T) { | ||
| r := &gitkit.Receiver{ | ||
| AllowedRefs: tc.allowedBranches, | ||
| } | ||
|
|
||
| err := r.CheckAllowedBranch(&gitkit.HookInfo{ | ||
| Ref: tc.ref, | ||
| }) | ||
|
|
||
| assert.Equal(t, tc.err, err) | ||
| }) | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly updated to be able to use some functions and also, newer is better. :D