Skip to content

Commit

Permalink
Merge pull request #78 from sourcefuse/version-update
Browse files Browse the repository at this point in the history
updating provide, Tf versions and db_parameter_group
  • Loading branch information
mayank0202 authored Jul 11, 2024
2 parents 8e0252b + 1195d7a commit 6d2288c
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 8 deletions.
6 changes: 5 additions & 1 deletion example/.terraform.lock.hcl

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions example/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
## defaults
################################################################################
terraform {
required_version = ">= 1.3, < 2.0.0"
required_version = "~> 1.3, < 2.0.0"

required_providers {
aws = {
source = "hashicorp/aws"
version = ">= 4.0"
version = ">= 4.0, < 6.0"
}
}
}
Expand Down Expand Up @@ -74,7 +74,7 @@ module "rds_sql_server" {
rds_instance_engine = "sqlserver-ex" // express edition.
rds_instance_engine_version = "16.00.4105.2.v1"
rds_instance_major_engine_version = "16.00"
rds_instance_db_parameter_group = "default.sqlserver-ex-16.0"
rds_instance_db_parameter_group = "sqlserver-ex-16.0"
rds_instance_db_parameter = []
rds_instance_db_options = []
rds_enable_custom_option_group = true
Expand All @@ -83,7 +83,7 @@ module "rds_sql_server" {
rds_instance_multi_az = false
rds_instance_storage_type = "gp3"
rds_instance_instance_class = "db.t3.small"
rds_instance_allocated_storage = 25
rds_instance_allocated_storage = 400
rds_instance_storage_encrypted = false // sql server express doesn't support encryption at rest
rds_instance_snapshot_identifier = null
rds_instance_auto_minor_version_upgrade = true
Expand Down
2 changes: 1 addition & 1 deletion variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ variable "rds_instance_database_port" {
variable "rds_instance_engine" {
type = string
description = "Database engine type. Required unless a snapshot_identifier or replicate_source_db is provided. For supported values, see the Engine parameter in API action CreateDBInstance."
default = "postgres"
default = "sqlserver-*"
}

variable "rds_instance_engine_version" {
Expand Down
4 changes: 2 additions & 2 deletions versions.tf
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
terraform {
required_version = ">= 1.3, < 2.0.0"
required_version = "~> 1.3, < 2.0.0"

required_providers {
aws = {
source = "hashicorp/aws"
version = ">= 4.0"
version = ">= 4.0, < 6.0"
}

null = {
Expand Down

0 comments on commit 6d2288c

Please sign in to comment.