fix(core): is column should be mandatory

is column needs to be mandatory in valid WF GH-72
sourcefuse · Mar 26, 2024 · 0b4e4c2 · 0b4e4c2
1 parent 284545b
commit 0b4e4c2
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/projects/workflows-creator/src/lib/builder/builder.component.ts b/projects/workflows-creator/src/lib/builder/builder.component.ts
@@ -48,6 +48,7 @@ import {
 } from '../types';
 import {LocalizationProviderService} from '../services/localization-provider.service';
 import {LocalizationPipe} from '../pipes/localization.pipe';
+import {ConditionInput} from '../services';
 @Component({
   selector: 'workflow-builder',
   templateUrl: './builder.component.html',
@@ -487,6 +488,14 @@ export class BuilderComponent<E> implements OnInit, OnChanges {
           case ActionTypes.ChangeColumnValueAction:
             const columnExists = !!node.node.state.get('column');
             let valueExists = false;
+            const valueTypeIsAnyValue =
+              node.node.state.get('valueType') === ValueTypes.AnyValue;
+            let conditionExist = false;
+            if (node.node.prompts.includes(ConditionInput.identifier)) {
+              conditionExist = !!node.node.state.get('condition');
+            } else {
+              conditionExist = true;
+            }
             if (typeof node.node.state.get('value') !== 'undefined') {
               valueExists = true;
             } else if (
@@ -496,9 +505,11 @@ export class BuilderComponent<E> implements OnInit, OnChanges {
             } else {
               valueExists = !!node.node.state.get('value');
             }
-            const valueTypeIsAnyValue =
-              node.node.state.get('valueType') === ValueTypes.AnyValue;
-            isValid = columnExists && (valueExists || valueTypeIsAnyValue);
+
+            isValid =
+              columnExists &&
+              (valueExists || valueTypeIsAnyValue) &&
+              conditionExist;
             break;
           case EventTypes.OnIntervalEvent:
             const intervalExists = !!node.node.state.get('interval');

diff --git a/projects/workflows-element/package.json b/projects/workflows-element/package.json
@@ -17,6 +17,6 @@
     "access": "public",
     "directory": "dist"
   },
-  "hash": "2de169ac759548f51f2397daa81b6187fa75d7ca99c31f0f14e9ab95335919fb"
+  "hash": "e7d87648d791167bdf0951718bdf5aa7fd8813267d827776af30b4e2f6d3741e"
 }