Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executors: deploy on k8s #4224

Merged
merged 10 commits into from
Jan 30, 2023
Merged

executors: deploy on k8s #4224

merged 10 commits into from
Jan 30, 2023

Conversation

davejrt
Copy link
Contributor

@davejrt davejrt commented Jan 24, 2023

This is my interpretation of https://github.com/sourcegraph/sourcegraph/issues/42469

It's a WIP as there is no documentation but we need an artefact for folks to deploy as well, and before I can document the process, we need to agree on what that is.

Right now this creates a single replica, with yet to be determined resource requirements. It deploys a docker in docker sidecar to avoid exposing the underlying container runtime on the k8s host. It also deploys a pull through cache to avoid docker rate limiting.

Assuming this is good, further steps are to ensure this works with kustomize/helm and is documented with a readme and exisiting executor docs are amended.

Edit: @eseliger this was tested on k8s 1.24 with containerd as the underlying runtime. Given we are exposing docker in docker to this, we don't have any compatibility problems in the short/medium term whilst we potentially move away from calling docker directly.

Checklist

Test plan

Tested running a SSBC on S2

image

@davejrt davejrt requested review from eseliger and a team January 24, 2023 18:37
@davejrt davejrt changed the title executor: deploy on k8s WIP executor: deploy on k8s Jan 24, 2023
Copy link
Member

@eseliger eseliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks pretty solid to me :)

@eseliger
Copy link
Member

using a separate docker daemon actually seems really smart to work around the issues, great idea!

@davejrt davejrt requested a review from sanderginn January 30, 2023 13:47
@davejrt davejrt marked this pull request as ready for review January 30, 2023 13:47
@davejrt davejrt changed the title WIP executor: deploy on k8s executors: deploy on k8s Jan 30, 2023
@davejrt davejrt merged commit 03c0904 into master Jan 30, 2023
@davejrt davejrt deleted the dt/k8s_executor branch January 30, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants