Add support for Protobuf in Gradle projects #361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
force-pushed
the
protobuf-spike
branch
from
aa09234 to
831191a
Compare
Previously, lsif-java only indexed the generated code from proto files. Now, we also index the original proto files so that it's possible to navigate from Java/Scala/Kotlin to Protobuf (and vice-versa). This new feature only works for Gradle at the moment but the underlying approach is generic and can be reused for other build tools as well.
olafurpg
force-pushed
the
protobuf-spike
branch
from
831191a to
13f40f3
Compare
|
We have validated that the overall approach is good but we want to complete the following upstream issue before shipping Protobuf support. Closing this PR until we pick this up again https://github.com/sourcegraph/sourcegraph/issues/27403 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, lsif-java only indexed the generated code from proto files.
Now, we also index the original proto files so that it's possible to
navigate from Java/Scala/Kotlin to Protobuf (and vice-versa).
This new feature only works for Gradle at the moment but the underlying
approach is generic and can be reused for other build tools as well.
Towards #363
TODOs:
java_packagejava_multiple_filesjava_outer_classnamemapmessagerepeatedenumstringdoublefloatint32int64uint32uint64sint32sint64fixed32fixed64sfixed32sfixed64boolbytesoneofservicerpcgoogle.protobuf.Anyoptimize_for = SPEEDoptimize_for = CODE_SIZEoptimize_for = LITE_RUNTIME