Skip to content

Commit

Permalink
Stop storing instance location pointers when marking evaluation (#317)
Browse files Browse the repository at this point in the history 
Signed-off-by: Juan Cruz Viotti <[email protected]>
  • Loading branch information
@jviotti
jviotti authored Dec 19, 2024
1 parent 6074caa commit a151e14
Show file tree
Hide file tree
Showing 4 changed files with 161 additions and 73 deletions.
Loading

5 comments on commit a151e14

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: a151e14 Previous: 6074caa Ratio
Compiler_Draft6_AdaptiveCard 50365747000.999985 ns/iter 49816557368.99998 ns/iter 1.01
Compiler_2019_09_OMC_JSON_V2 10689255725.00001 ns/iter 10565353889.999983 ns/iter 1.01
Evaluator_Draft4_Meta_1_No_Callback 240.14886313184687 ns/iter 243.6694755922361 ns/iter 0.99
Evaluator_Draft4_Required_Properties 614.8144810787496 ns/iter 609.7934566734683 ns/iter 1.01
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 28.994875270903343 ns/iter 28.549375794956795 ns/iter 1.02
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 16.496696221191343 ns/iter 16.993269477144235 ns/iter 0.97
Evaluator_Draft4_Items_Schema 615.9569029604331 ns/iter 606.1480539890346 ns/iter 1.02
Evaluator_Draft4_Nested_Object 4.9753471843899195 ns/iter 5.282908540114769 ns/iter 0.94
Evaluator_Draft4_Properties_Triad_Optional 892.547058602328 ns/iter 862.8579175771956 ns/iter 1.03
Evaluator_Draft4_Properties_Triad_Closed 697.7217247912209 ns/iter 689.4014357969376 ns/iter 1.01
Evaluator_Draft4_Properties_Triad_Required 898.2817664266637 ns/iter 901.0328875662107 ns/iter 1.00
Evaluator_Draft4_Properties_Closed 76.78956036521929 ns/iter 76.68518253827153 ns/iter 1.00
Evaluator_Draft4_Non_Recursive_Ref 28.93862388258121 ns/iter 29.5875226057789 ns/iter 0.98
Evaluator_Draft4_Pattern_Properties_True 249.3401924547514 ns/iter 235.62534523684323 ns/iter 1.06
Evaluator_Draft4_Ref_To_Single_Property 16.491070051924456 ns/iter 16.813158435600194 ns/iter 0.98
Evaluator_Draft4_Additional_Properties_Type 52.83182770219744 ns/iter 53.531817258568225 ns/iter 0.99
Evaluator_Draft4_Nested_Oneof 86.07831821492583 ns/iter 89.72621234851438 ns/iter 0.96
Evaluator_Draft4_Long_Enum 19.91981338306034 ns/iter 19.71526132228265 ns/iter 1.01
Evaluator_Draft4_Type_Object 10.304740188602436 ns/iter 10.272751531384488 ns/iter 1.00
Evaluator_Draft6_Property_Names 135.28933374610668 ns/iter 128.0265640919651 ns/iter 1.06
Evaluator_Draft7_If_Then_Else 40.47505070403531 ns/iter 40.138625787847666 ns/iter 1.01
Evaluator_Draft7_Vercel_1 47417.95127910414 ns/iter 54839.20470306708 ns/iter 0.86
Evaluator_Draft7_Helm_Chart_Lock_1 317.67645171857924 ns/iter 312.97914368359176 ns/iter 1.02
Evaluator_Draft7_Jasmine_1 171.68199902168809 ns/iter 172.33944474812213 ns/iter 1.00
Evaluator_2019_09_Unevaluated_Properties 176.59002874166202 ns/iter 203.64214672727525 ns/iter 0.87
Evaluator_2019_09_OMC_JSON_V2_1 1365.330961055499 ns/iter 1423.8955589697168 ns/iter 0.96
Evaluator_2020_12_Dynamic_Ref 570.4166303665892 ns/iter 588.7473967022775 ns/iter 0.97
Evaluator_2020_12_Dynamic_Ref_Single 10.598760053758756 ns/iter 10.273668970551785 ns/iter 1.03
Evaluator_2020_12_CQL_1 4114.413122470898 ns/iter 4139.096922837564 ns/iter 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: a151e14 Previous: 6074caa Ratio
Compiler_Draft6_AdaptiveCard 37982264958.99996 ns/iter 34208210000.000008 ns/iter 1.11
Compiler_2019_09_OMC_JSON_V2 7803421125 ns/iter 7807428834.000007 ns/iter 1.00
Evaluator_Draft4_Meta_1_No_Callback 169.52219706443344 ns/iter 165.97943144363475 ns/iter 1.02
Evaluator_Draft4_Required_Properties 440.53085935584767 ns/iter 436.74520013159304 ns/iter 1.01
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 20.407556211892576 ns/iter 19.34411614075402 ns/iter 1.05
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 9.412251985380788 ns/iter 9.34591955167533 ns/iter 1.01
Evaluator_Draft4_Items_Schema 290.26106024380357 ns/iter 263.08545588673877 ns/iter 1.10
Evaluator_Draft4_Nested_Object 3.168829290602692 ns/iter 3.1745745923314557 ns/iter 1.00
Evaluator_Draft4_Properties_Triad_Optional 739.213114284114 ns/iter 730.6721874404901 ns/iter 1.01
Evaluator_Draft4_Properties_Triad_Closed 612.4135060674348 ns/iter 603.6089147320185 ns/iter 1.01
Evaluator_Draft4_Properties_Triad_Required 746.6476428921494 ns/iter 744.9605435175862 ns/iter 1.00
Evaluator_Draft4_Properties_Closed 46.82344389968793 ns/iter 47.78459161639012 ns/iter 0.98
Evaluator_Draft4_Non_Recursive_Ref 9.444842028204102 ns/iter 9.59046472963565 ns/iter 0.98
Evaluator_Draft4_Pattern_Properties_True 161.49196803473617 ns/iter 161.8043630500435 ns/iter 1.00
Evaluator_Draft4_Ref_To_Single_Property 9.335015314699513 ns/iter 9.33802950593043 ns/iter 1.00
Evaluator_Draft4_Additional_Properties_Type 15.825294083207371 ns/iter 16.77529196553125 ns/iter 0.94
Evaluator_Draft4_Nested_Oneof 48.54820839532483 ns/iter 48.59863728402769 ns/iter 1.00
Evaluator_Draft4_Long_Enum 26.979159944410096 ns/iter 26.55009722539245 ns/iter 1.02
Evaluator_Draft4_Type_Object 5.424239061274556 ns/iter 5.395897438871249 ns/iter 1.01
Evaluator_Draft6_Property_Names 86.95587012514707 ns/iter 85.74473170661203 ns/iter 1.01
Evaluator_Draft7_If_Then_Else 24.361715038066105 ns/iter 24.312945535297263 ns/iter 1.00
Evaluator_Draft7_Vercel_1 34172.1125186308 ns/iter 36729.56084573538 ns/iter 0.93
Evaluator_Draft7_Helm_Chart_Lock_1 140.65625425344274 ns/iter 141.30707192189445 ns/iter 1.00
Evaluator_Draft7_Jasmine_1 119.84339492469712 ns/iter 120.38241363011254 ns/iter 1.00
Evaluator_2019_09_Unevaluated_Properties 167.49892434203753 ns/iter 172.5904696485629 ns/iter 0.97
Evaluator_2019_09_OMC_JSON_V2_1 997.6259130468727 ns/iter 1048.660372117598 ns/iter 0.95
Evaluator_2020_12_Dynamic_Ref 370.39195912442176 ns/iter 372.62044775663037 ns/iter 0.99
Evaluator_2020_12_Dynamic_Ref_Single 5.387232458259862 ns/iter 5.501232099899611 ns/iter 0.98
Evaluator_2020_12_CQL_1 2357.759238937069 ns/iter 2353.117550357502 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: a151e14 Previous: 6074caa Ratio
Evaluator_2020_12_Dynamic_Ref 621.8932647881916 ns/iter 615.5988941301994 ns/iter 1.01
Evaluator_2020_12_Dynamic_Ref_Single 9.393608100155248 ns/iter 9.343152297423215 ns/iter 1.01
Evaluator_2020_12_CQL_1 4129.6656558400555 ns/iter 4154.420913868298 ns/iter 0.99
Evaluator_2019_09_Unevaluated_Properties 187.29953627693334 ns/iter 236.85114980861314 ns/iter 0.79
Evaluator_2019_09_OMC_JSON_V2_1 1382.4227249944965 ns/iter 1393.0676808735248 ns/iter 0.99
Evaluator_Draft7_If_Then_Else 43.87860122096322 ns/iter 42.96442117190535 ns/iter 1.02
Evaluator_Draft7_Vercel_1 46693.6111443558 ns/iter 48564.853752798204 ns/iter 0.96
Evaluator_Draft7_Helm_Chart_Lock_1 197.40082066404688 ns/iter 198.44719698527143 ns/iter 0.99
Evaluator_Draft7_Jasmine_1 152.3099260086355 ns/iter 153.92036916784042 ns/iter 0.99
Evaluator_Draft6_Property_Names 148.15263414731444 ns/iter 139.86231645119622 ns/iter 1.06
Evaluator_Draft4_Meta_1_No_Callback 231.58411789744127 ns/iter 229.36348507924933 ns/iter 1.01
Evaluator_Draft4_Required_Properties 451.54532604586757 ns/iter 455.05825756607635 ns/iter 0.99
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 26.18919748853972 ns/iter 25.6516499205703 ns/iter 1.02
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 12.164289865073384 ns/iter 12.191057967826199 ns/iter 1.00
Evaluator_Draft4_Items_Schema 502.297229000078 ns/iter 500.3986268089719 ns/iter 1.00
Evaluator_Draft4_Nested_Object 3.830112052890075 ns/iter 4.056859111631434 ns/iter 0.94
Evaluator_Draft4_Properties_Triad_Optional 1023.9884158791675 ns/iter 1055.5222168782927 ns/iter 0.97
Evaluator_Draft4_Properties_Triad_Closed 825.2631439583772 ns/iter 845.2336280234267 ns/iter 0.98
Evaluator_Draft4_Properties_Triad_Required 1031.193063687132 ns/iter 1031.3908362228888 ns/iter 1.00
Evaluator_Draft4_Properties_Closed 71.56020884908158 ns/iter 72.2437633060716 ns/iter 0.99
Evaluator_Draft4_Non_Recursive_Ref 12.458103367697138 ns/iter 12.453962779744938 ns/iter 1.00
Evaluator_Draft4_Pattern_Properties_True 271.86585289084906 ns/iter 265.11167184954684 ns/iter 1.03
Evaluator_Draft4_Ref_To_Single_Property 12.189155622055312 ns/iter 12.159449844927213 ns/iter 1.00
Evaluator_Draft4_Additional_Properties_Type 15.370155150914817 ns/iter 14.978546626309823 ns/iter 1.03
Evaluator_Draft4_Nested_Oneof 108.06899135360528 ns/iter 107.64475251948315 ns/iter 1.00
Evaluator_Draft4_Long_Enum 18.444936532267594 ns/iter 18.39107340309551 ns/iter 1.00
Evaluator_Draft4_Type_Object 9.385729055984056 ns/iter 9.357055908064364 ns/iter 1.00
Compiler_2019_09_OMC_JSON_V2 10228729272.00001 ns/iter 10202972591.999924 ns/iter 1.00
Compiler_Draft6_AdaptiveCard 51635701119.00003 ns/iter 51162638474.00001 ns/iter 1.01

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/gcc)

Benchmark suite Current: a151e14 Previous: 6074caa Ratio
Compiler_Draft6_AdaptiveCard 53067286968.2312 ns/iter 48005552768.707275 ns/iter 1.11
Compiler_2019_09_OMC_JSON_V2 10948104858.398438 ns/iter 8499687910.079956 ns/iter 1.29
Evaluator_Draft4_Meta_1_No_Callback 183.337149629211 ns/iter 167.03389371780975 ns/iter 1.10
Evaluator_Draft4_Required_Properties 451.56167607703907 ns/iter 402.18734617455164 ns/iter 1.12
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 20.09878672054569 ns/iter 18.900654900069128 ns/iter 1.06
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 11.137188745373747 ns/iter 9.883146759459262 ns/iter 1.13
Evaluator_Draft4_Items_Schema 586.0432908378169 ns/iter 482.3662415470515 ns/iter 1.21
Evaluator_Draft4_Nested_Object 2.8504863528195945 ns/iter 2.2132892233633323 ns/iter 1.29
Evaluator_Draft4_Properties_Triad_Optional 903.6454301513813 ns/iter 830.5132561081726 ns/iter 1.09
Evaluator_Draft4_Properties_Triad_Closed 677.1155555383006 ns/iter 657.1348731848053 ns/iter 1.03
Evaluator_Draft4_Properties_Triad_Required 822.9118945701288 ns/iter 844.3930626205278 ns/iter 0.97
Evaluator_Draft4_Properties_Closed 67.94423997285945 ns/iter 68.16479695892693 ns/iter 1.00
Evaluator_Draft4_Non_Recursive_Ref 13.490896935286 ns/iter 13.518991982774448 ns/iter 1.00
Evaluator_Draft4_Pattern_Properties_True 183.54455542440877 ns/iter 187.88600136130947 ns/iter 0.98
Evaluator_Draft4_Ref_To_Single_Property 10.124419472739188 ns/iter 9.874959346968932 ns/iter 1.03
Evaluator_Draft4_Additional_Properties_Type 25.55671904324881 ns/iter 25.670013275762972 ns/iter 1.00
Evaluator_Draft4_Nested_Oneof 57.65663752671985 ns/iter 58.491389971515986 ns/iter 0.99
Evaluator_Draft4_Long_Enum 9.159619995487363 ns/iter 9.178849450847574 ns/iter 1.00
Evaluator_Draft4_Type_Object 4.828442728435606 ns/iter 5.038364686852684 ns/iter 0.96
Evaluator_Draft6_Property_Names 117.10354152107422 ns/iter 121.01195247634087 ns/iter 0.97
Evaluator_Draft7_If_Then_Else 26.541932242697403 ns/iter 26.618715834217785 ns/iter 1.00
Evaluator_Draft7_Vercel_1 38817.439199379354 ns/iter 93366.34951275053 ns/iter 0.42
Evaluator_Draft7_Helm_Chart_Lock_1 206.41104169511604 ns/iter 220.42137146020218 ns/iter 0.94
Evaluator_Draft7_Jasmine_1 132.48408610951213 ns/iter 131.31765675481833 ns/iter 1.01
Evaluator_2019_09_Unevaluated_Properties 160.96122690177157 ns/iter 178.12816477055804 ns/iter 0.90
Evaluator_2019_09_OMC_JSON_V2_1 1059.7534614213782 ns/iter 993.5376579056322 ns/iter 1.07
Evaluator_2020_12_Dynamic_Ref 458.16871138347244 ns/iter 445.9072657142351 ns/iter 1.03
Evaluator_2020_12_Dynamic_Ref_Single 4.821809387831063 ns/iter 4.564384422244501 ns/iter 1.06
Evaluator_2020_12_CQL_1 2895.5735738971794 ns/iter 2944.778997296204 ns/iter 0.98

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: a151e14 Previous: 6074caa Ratio
Compiler_Draft6_AdaptiveCard 114088865899.99997 ns/iter 114474555199.99994 ns/iter 1.00
Compiler_2019_09_OMC_JSON_V2 21644283799.999924 ns/iter 21883158900.00001 ns/iter 0.99
Evaluator_Draft4_Meta_1_No_Callback 366.1270060487871 ns/iter 362.3176300141805 ns/iter 1.01
Evaluator_Draft4_Required_Properties 918.445706051032 ns/iter 939.941633954583 ns/iter 0.98
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 42.845425064062276 ns/iter 37.80710937499876 ns/iter 1.13
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 21.674534375001997 ns/iter 22.143668750000952 ns/iter 0.98
Evaluator_Draft4_Items_Schema 698.1034821428977 ns/iter 722.2796428571598 ns/iter 0.97
Evaluator_Draft4_Nested_Object 6.207236607143127 ns/iter 6.2219732142858275 ns/iter 1.00
Evaluator_Draft4_Properties_Triad_Optional 1572.3625185072485 ns/iter 1655.3455357143525 ns/iter 0.95
Evaluator_Draft4_Properties_Triad_Closed 1269.1257142857842 ns/iter 1340.857321428603 ns/iter 0.95
Evaluator_Draft4_Properties_Triad_Required 1586.11938429511 ns/iter 1670.9729910712972 ns/iter 0.95
Evaluator_Draft4_Properties_Closed 90.49391113865894 ns/iter 98.48182596062925 ns/iter 0.92
Evaluator_Draft4_Non_Recursive_Ref 31.71129424549067 ns/iter 32.221313003460615 ns/iter 0.98
Evaluator_Draft4_Pattern_Properties_True 223.87688349586892 ns/iter 233.34894717086325 ns/iter 0.96
Evaluator_Draft4_Ref_To_Single_Property 21.913171722053292 ns/iter 22.30082812499745 ns/iter 0.98
Evaluator_Draft4_Additional_Properties_Type 58.39012000000138 ns/iter 58.106839285707274 ns/iter 1.00
Evaluator_Draft4_Nested_Oneof 110.00004687501175 ns/iter 108.53576785714431 ns/iter 1.01
Evaluator_Draft4_Long_Enum 23.351942819732965 ns/iter 23.236332329953285 ns/iter 1.00
Evaluator_Draft4_Type_Object 13.155208928572344 ns/iter 13.621853510616084 ns/iter 0.97
Evaluator_Draft6_Property_Names 165.62279017858626 ns/iter 157.5090624999831 ns/iter 1.05
Evaluator_Draft7_If_Then_Else 53.92017857143319 ns/iter 54.44800892857212 ns/iter 0.99
Evaluator_Draft7_Vercel_1 69632.29464286006 ns/iter 69854.74330356567 ns/iter 1.00
Evaluator_Draft7_Helm_Chart_Lock_1 323.9956443743322 ns/iter 321.33218749998656 ns/iter 1.01
Evaluator_Draft7_Jasmine_1 230.4507666907849 ns/iter 245.99739285711004 ns/iter 0.94
Evaluator_2019_09_Unevaluated_Properties 343.41006814106316 ns/iter 379.9818223837274 ns/iter 0.90
Evaluator_2019_09_OMC_JSON_V2_1 1908.5427754847158 ns/iter 1944.0416116539611 ns/iter 0.98
Evaluator_2020_12_Dynamic_Ref 846.5914524145511 ns/iter 850.1304687500116 ns/iter 1.00
Evaluator_2020_12_Dynamic_Ref_Single 13.514028287885665 ns/iter 13.347032083273376 ns/iter 1.01
Evaluator_2020_12_CQL_1 4745.3951906136035 ns/iter 4959.466000000248 ns/iter 0.96

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.