Skip to content

Commit

Permalink
Fix EVALUATE_END name for LoopItems (#228)
Browse files Browse the repository at this point in the history 
Signed-off-by: Juan Cruz Viotti <[email protected]>
  • Loading branch information
@jviotti
jviotti authored Nov 25, 2024
1 parent ec545ed commit f499c75
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/evaluator/dispatch.inc.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1288,7 +1288,7 @@ switch (static_cast<InstructionIndex>(instruction.index())) {
for (const auto &child : loop.children) {
if (!EVALUATE_RECURSE(child, new_instance)) {
result = false;
EVALUATE_END(loop, LoopItemsFrom);
EVALUATE_END(loop, LoopItems);
}
}
}
Expand All @@ -1304,7 +1304,7 @@ switch (static_cast<InstructionIndex>(instruction.index())) {
if (track) {
context.instance_location.pop_back();
}
EVALUATE_END(loop, LoopItemsFrom);
EVALUATE_END(loop, LoopItems);
}
}

Expand Down

5 comments on commit f499c75

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: f499c75 Previous: ec545ed Ratio
Compiler_Draft6_AdaptiveCard 33346006999.999985 ns/iter 36594986083.99997 ns/iter 0.91
Compiler_2019_09_OMC_JSON_V2 6699834791.999933 ns/iter 8258582583.00002 ns/iter 0.81
Evaluator_Draft4_Meta_1_No_Callback 250.80426140286238 ns/iter 300.89175746967214 ns/iter 0.83
Evaluator_Draft4_Required_Properties 335.22789911655747 ns/iter 394.3387415295907 ns/iter 0.85
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 18.43629495877398 ns/iter 19.574388126242784 ns/iter 0.94
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 10.108426671873412 ns/iter 11.56498834955244 ns/iter 0.87
Evaluator_Draft4_Items_Schema 334.45194638947777 ns/iter 383.94334131158934 ns/iter 0.87
Evaluator_Draft4_Nested_Object 2.911915468512387 ns/iter 3.4025020909038646 ns/iter 0.86
Evaluator_Draft4_Properties_Triad_Optional 766.260702950424 ns/iter 841.730562450337 ns/iter 0.91
Evaluator_Draft4_Properties_Triad_Closed 656.1004810654599 ns/iter 674.0512625051807 ns/iter 0.97
Evaluator_Draft4_Properties_Triad_Required 769.2092898912947 ns/iter 873.0198636276998 ns/iter 0.88
Evaluator_Draft4_Properties_Closed 78.31148337611948 ns/iter 85.57351315200937 ns/iter 0.92
Evaluator_Draft4_Non_Recursive_Ref 10.484781784503495 ns/iter 11.282680955010186 ns/iter 0.93
Evaluator_Draft4_Pattern_Properties_True 184.75110428196095 ns/iter 181.77535394499986 ns/iter 1.02
Evaluator_Draft4_Ref_To_Single_Property 11.87417845166732 ns/iter 11.363965726544805 ns/iter 1.04
Evaluator_Draft4_Additional_Properties_Type 21.339992992805897 ns/iter 21.21342518330187 ns/iter 1.01
Evaluator_Draft4_Nested_Oneof 70.62397379154004 ns/iter 74.65471264058539 ns/iter 0.95
Evaluator_Draft4_Long_Enum 28.3741338525381 ns/iter 30.70457804541259 ns/iter 0.92
Evaluator_Draft4_Type_Object 5.969484857117427 ns/iter 6.2524582838369485 ns/iter 0.95
Evaluator_Draft6_Property_Names 136.86391109687878 ns/iter 154.3868440837663 ns/iter 0.89
Evaluator_Draft7_If_Then_Else 28.181968337364335 ns/iter 29.486684322718208 ns/iter 0.96
Evaluator_Draft7_Vercel_1 73653.09636163173 ns/iter 86853.04149084799 ns/iter 0.85
Evaluator_Draft7_Helm_Chart_Lock_1 363.6963097164803 ns/iter 414.26145839771857 ns/iter 0.88
Evaluator_2019_09_Unevaluated_Properties 147.73751093257306 ns/iter 159.32815825982047 ns/iter 0.93
Evaluator_2019_09_OMC_JSON_V2_1 2618.8281457295357 ns/iter 2720.981349568225 ns/iter 0.96
Evaluator_2020_12_Dynamic_Ref 512.5730276063028 ns/iter 506.43991176204764 ns/iter 1.01

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: f499c75 Previous: ec545ed Ratio
Compiler_Draft6_AdaptiveCard 53349703583.00001 ns/iter 53658336624.000015 ns/iter 0.99
Compiler_2019_09_OMC_JSON_V2 10764566467.999998 ns/iter 10783066971.999971 ns/iter 1.00
Evaluator_Draft4_Meta_1_No_Callback 348.67392599477535 ns/iter 351.17106150414037 ns/iter 0.99
Evaluator_Draft4_Required_Properties 750.4758527434129 ns/iter 766.4289718715507 ns/iter 0.98
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 36.185504172589965 ns/iter 36.489831218648504 ns/iter 0.99
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 23.188448590623427 ns/iter 23.498569007465118 ns/iter 0.99
Evaluator_Draft4_Items_Schema 693.1947463583441 ns/iter 690.2468819842449 ns/iter 1.00
Evaluator_Draft4_Nested_Object 4.357055739089767 ns/iter 4.346602027409223 ns/iter 1.00
Evaluator_Draft4_Properties_Triad_Optional 1218.7476200929311 ns/iter 1181.8669265183678 ns/iter 1.03
Evaluator_Draft4_Properties_Triad_Closed 991.5265562204928 ns/iter 990.7999443000612 ns/iter 1.00
Evaluator_Draft4_Properties_Triad_Required 1217.0630095047238 ns/iter 1213.6751977267115 ns/iter 1.00
Evaluator_Draft4_Properties_Closed 128.9784498415648 ns/iter 132.24494043975747 ns/iter 0.98
Evaluator_Draft4_Non_Recursive_Ref 28.486942545787873 ns/iter 28.485624023512784 ns/iter 1.00
Evaluator_Draft4_Pattern_Properties_True 249.36014089876682 ns/iter 253.9708217688539 ns/iter 0.98
Evaluator_Draft4_Ref_To_Single_Property 22.89139655302935 ns/iter 23.262672264594386 ns/iter 0.98
Evaluator_Draft4_Additional_Properties_Type 55.49277276548591 ns/iter 54.103390868912776 ns/iter 1.03
Evaluator_Draft4_Nested_Oneof 126.15493544236838 ns/iter 126.17537202680514 ns/iter 1.00
Evaluator_Draft4_Long_Enum 20.46331533063324 ns/iter 20.67739919327677 ns/iter 0.99
Evaluator_Draft4_Type_Object 10.220248571407344 ns/iter 10.231359844484777 ns/iter 1.00
Evaluator_Draft6_Property_Names 249.35036787888004 ns/iter 268.2722137698304 ns/iter 0.93
Evaluator_Draft7_If_Then_Else 54.71983941264358 ns/iter 54.77174349638009 ns/iter 1.00
Evaluator_Draft7_Vercel_1 100077.30874514104 ns/iter 101978.82080586205 ns/iter 0.98
Evaluator_Draft7_Helm_Chart_Lock_1 563.4556526489486 ns/iter 573.0647281996067 ns/iter 0.98
Evaluator_2019_09_Unevaluated_Properties 192.05477835256892 ns/iter 194.54790538667234 ns/iter 0.99
Evaluator_2019_09_OMC_JSON_V2_1 3385.502158027249 ns/iter 3368.910056894064 ns/iter 1.00
Evaluator_2020_12_Dynamic_Ref 829.9255303052004 ns/iter 819.2945968849185 ns/iter 1.01

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: f499c75 Previous: ec545ed Ratio
Evaluator_2020_12_Dynamic_Ref 844.7089116889346 ns/iter 841.4471846753042 ns/iter 1.00
Evaluator_2019_09_Unevaluated_Properties 234.1802387511785 ns/iter 235.76679721956103 ns/iter 0.99
Evaluator_2019_09_OMC_JSON_V2_1 5232.363781700134 ns/iter 5061.631429999807 ns/iter 1.03
Evaluator_Draft7_If_Then_Else 51.04964417467412 ns/iter 50.988775704308104 ns/iter 1.00
Evaluator_Draft7_Vercel_1 114047.43363119612 ns/iter 115190.9964297315 ns/iter 0.99
Evaluator_Draft7_Helm_Chart_Lock_1 715.7120860133332 ns/iter 725.7928223030498 ns/iter 0.99
Evaluator_Draft6_Property_Names 499.6096636624369 ns/iter 497.38392399040345 ns/iter 1.00
Evaluator_Draft4_Meta_1_No_Callback 430.90806458913886 ns/iter 427.23693264829916 ns/iter 1.01
Evaluator_Draft4_Required_Properties 1708.8573819960889 ns/iter 1704.83151411477 ns/iter 1.00
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 39.01178082901176 ns/iter 38.20329786172623 ns/iter 1.02
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 33.20377162958091 ns/iter 32.966965602491705 ns/iter 1.01
Evaluator_Draft4_Items_Schema 528.4603446046023 ns/iter 532.3970799655883 ns/iter 0.99
Evaluator_Draft4_Nested_Object 3.480836022687745 ns/iter 3.4876296385885026 ns/iter 1.00
Evaluator_Draft4_Properties_Triad_Optional 1213.9623032262507 ns/iter 1224.4578649761245 ns/iter 0.99
Evaluator_Draft4_Properties_Triad_Closed 1010.0824354600495 ns/iter 1021.4799535919237 ns/iter 0.99
Evaluator_Draft4_Properties_Triad_Required 1282.0872838343707 ns/iter 1288.9572690633554 ns/iter 0.99
Evaluator_Draft4_Properties_Closed 185.5268995406983 ns/iter 186.02225263417174 ns/iter 1.00
Evaluator_Draft4_Non_Recursive_Ref 48.73623359932639 ns/iter 48.49884051098395 ns/iter 1.00
Evaluator_Draft4_Pattern_Properties_True 346.3627350684386 ns/iter 345.60303272504177 ns/iter 1.00
Evaluator_Draft4_Ref_To_Single_Property 36.40437859137754 ns/iter 36.37760451265992 ns/iter 1.00
Evaluator_Draft4_Additional_Properties_Type 102.94527579443347 ns/iter 103.10860102428082 ns/iter 1.00
Evaluator_Draft4_Nested_Oneof 112.53085638700603 ns/iter 112.36160558487299 ns/iter 1.00
Evaluator_Draft4_Long_Enum 19.968073915251615 ns/iter 19.331734100118613 ns/iter 1.03
Evaluator_Draft4_Type_Object 10.01740797105483 ns/iter 10.081457635326696 ns/iter 0.99
Compiler_2019_09_OMC_JSON_V2 11077471561.000038 ns/iter 11302584556.999931 ns/iter 0.98
Compiler_Draft6_AdaptiveCard 60833475780.99995 ns/iter 61028300676.99995 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/gcc)

Benchmark suite Current: f499c75 Previous: ec545ed Ratio
Compiler_Draft6_AdaptiveCard 47290436029.434204 ns/iter 42390283823.013306 ns/iter 1.12
Compiler_2019_09_OMC_JSON_V2 9341125726.69983 ns/iter 7983206033.706665 ns/iter 1.17
Evaluator_Draft4_Meta_1_No_Callback 278.62898264144235 ns/iter 284.31995148808284 ns/iter 0.98
Evaluator_Draft4_Required_Properties 496.31907590346077 ns/iter 458.09679192763247 ns/iter 1.08
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 25.16371377933771 ns/iter 23.433161050453503 ns/iter 1.07
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 17.360058824857823 ns/iter 13.93899082295026 ns/iter 1.25
Evaluator_Draft4_Items_Schema 555.6920715669226 ns/iter 516.5070385044693 ns/iter 1.08
Evaluator_Draft4_Nested_Object 2.1659312766546566 ns/iter 1.98691931184684 ns/iter 1.09
Evaluator_Draft4_Properties_Triad_Optional 906.2277426722103 ns/iter 843.2075699167567 ns/iter 1.07
Evaluator_Draft4_Properties_Triad_Closed 832.7373090325539 ns/iter 714.8023142514543 ns/iter 1.16
Evaluator_Draft4_Properties_Triad_Required 911.7091615726158 ns/iter 843.3555158270119 ns/iter 1.08
Evaluator_Draft4_Properties_Closed 104.39722268224573 ns/iter 97.28793132249943 ns/iter 1.07
Evaluator_Draft4_Non_Recursive_Ref 20.74900894972158 ns/iter 19.72715235235703 ns/iter 1.05
Evaluator_Draft4_Pattern_Properties_True 237.1045361695972 ns/iter 232.4764380827239 ns/iter 1.02
Evaluator_Draft4_Ref_To_Single_Property 14.102084544083226 ns/iter 13.828282605601721 ns/iter 1.02
Evaluator_Draft4_Additional_Properties_Type 38.811621560393064 ns/iter 37.318989412040104 ns/iter 1.04
Evaluator_Draft4_Nested_Oneof 85.95052925406864 ns/iter 79.7385963548026 ns/iter 1.08
Evaluator_Draft4_Long_Enum 12.62086273826258 ns/iter 11.424403932614712 ns/iter 1.10
Evaluator_Draft4_Type_Object 7.006008027462679 ns/iter 6.588513807529392 ns/iter 1.06
Evaluator_Draft6_Property_Names 183.468737352967 ns/iter 178.11807910145578 ns/iter 1.03
Evaluator_Draft7_If_Then_Else 34.499913030166525 ns/iter 31.76158987981728 ns/iter 1.09
Evaluator_Draft7_Vercel_1 89500.81484676934 ns/iter 81102.45908045332 ns/iter 1.10
Evaluator_Draft7_Helm_Chart_Lock_1 432.86690334682123 ns/iter 391.2832538867461 ns/iter 1.11
Evaluator_2019_09_Unevaluated_Properties 167.97529233719914 ns/iter 162.03385009952456 ns/iter 1.04
Evaluator_2019_09_OMC_JSON_V2_1 2585.1657733581874 ns/iter 2519.6101902065006 ns/iter 1.03
Evaluator_2020_12_Dynamic_Ref 590.0549101819048 ns/iter 556.5673392877951 ns/iter 1.06

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: f499c75 Previous: ec545ed Ratio
Compiler_Draft6_AdaptiveCard 121106793299.99994 ns/iter 122265976200.00006 ns/iter 0.99
Compiler_2019_09_OMC_JSON_V2 25404735699.999947 ns/iter 25666284099.999985 ns/iter 0.99
Evaluator_Draft4_Meta_1_No_Callback 437.19768749994614 ns/iter 444.79476032283105 ns/iter 0.98
Evaluator_Draft4_Required_Properties 710.0300000000663 ns/iter 710.3251785713788 ns/iter 1.00
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match 35.49051358018342 ns/iter 35.46600472382312 ns/iter 1.00
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match 21.693728125001144 ns/iter 21.792340625005124 ns/iter 1.00
Evaluator_Draft4_Items_Schema 645.6233035714425 ns/iter 648.7082142856236 ns/iter 1.00
Evaluator_Draft4_Nested_Object 4.041612953645293 ns/iter 4.029683132195716 ns/iter 1.00
Evaluator_Draft4_Properties_Triad_Optional 1737.5939480396698 ns/iter 1737.7749077399935 ns/iter 1.00
Evaluator_Draft4_Properties_Triad_Closed 1438.8793266429286 ns/iter 1427.274206573987 ns/iter 1.01
Evaluator_Draft4_Properties_Triad_Required 1758.9069275957572 ns/iter 1754.4561019266164 ns/iter 1.00
Evaluator_Draft4_Properties_Closed 134.565928571411 ns/iter 137.80443804443337 ns/iter 0.98
Evaluator_Draft4_Non_Recursive_Ref 15.767430803573948 ns/iter 16.724277120146503 ns/iter 0.94
Evaluator_Draft4_Pattern_Properties_True 275.2617332472756 ns/iter 275.68404132514587 ns/iter 1.00
Evaluator_Draft4_Ref_To_Single_Property 22.651875000001098 ns/iter 22.772330102990406 ns/iter 0.99
Evaluator_Draft4_Additional_Properties_Type 30.614831951567712 ns/iter 30.627558291049528 ns/iter 1.00
Evaluator_Draft4_Nested_Oneof 153.89363839284036 ns/iter 156.36968749999727 ns/iter 0.98
Evaluator_Draft4_Long_Enum 22.094216271268277 ns/iter 22.43743750000249 ns/iter 0.98
Evaluator_Draft4_Type_Object 10.222335937498883 ns/iter 10.235020312499898 ns/iter 1.00
Evaluator_Draft6_Property_Names 417.58923712326543 ns/iter 418.3341479539812 ns/iter 1.00
Evaluator_Draft7_If_Then_Else 54.05676000000312 ns/iter 53.91830999999456 ns/iter 1.00
Evaluator_Draft7_Vercel_1 111182.1406249902 ns/iter 111920.65624999971 ns/iter 0.99
Evaluator_Draft7_Helm_Chart_Lock_1 627.6057142857537 ns/iter 625.5883999999696 ns/iter 1.00
Evaluator_2019_09_Unevaluated_Properties 437.11724999994317 ns/iter 427.620040029883 ns/iter 1.02
Evaluator_2019_09_OMC_JSON_V2_1 4441.589999998996 ns/iter 4427.057499999875 ns/iter 1.00
Evaluator_2020_12_Dynamic_Ref 1356.1268276222231 ns/iter 1365.1322477084834 ns/iter 0.99

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.