-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only maintain the evaluate path in "track" mode for applicators #325
Conversation
ba4a9fe
to
e15a07f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (linux/llvm)
Benchmark suite | Current: 5edc81a | Previous: 5b88c12 | Ratio |
---|---|---|---|
Compiler_Draft6_AdaptiveCard |
58822525343.999985 ns/iter |
57915559003 ns/iter |
1.02 |
Compiler_2019_09_OMC_JSON_V2 |
10781772101.000002 ns/iter |
10654768961.999992 ns/iter |
1.01 |
Evaluator_Draft4_Meta_1_No_Callback |
241.33604810698662 ns/iter |
246.32248416374568 ns/iter |
0.98 |
Evaluator_Draft4_Required_Properties |
633.87313196628 ns/iter |
613.8637922402044 ns/iter |
1.03 |
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match |
28.78953428137836 ns/iter |
29.198847370316713 ns/iter |
0.99 |
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match |
17.151950455742142 ns/iter |
17.16946612313176 ns/iter |
1.00 |
Evaluator_Draft4_Items_Schema |
640.1671008629469 ns/iter |
627.6807019152407 ns/iter |
1.02 |
Evaluator_Draft4_Nested_Object |
4.674053613031343 ns/iter |
5.032834278486049 ns/iter |
0.93 |
Evaluator_Draft4_Properties_Triad_Optional |
879.284274081525 ns/iter |
877.3343194625212 ns/iter |
1.00 |
Evaluator_Draft4_Properties_Triad_Closed |
693.9225413340732 ns/iter |
691.9668719537698 ns/iter |
1.00 |
Evaluator_Draft4_Properties_Triad_Required |
953.2376956469857 ns/iter |
905.7600014957883 ns/iter |
1.05 |
Evaluator_Draft4_Properties_Closed |
75.60426831453667 ns/iter |
76.41110625929514 ns/iter |
0.99 |
Evaluator_Draft4_Non_Recursive_Ref |
29.2463779021126 ns/iter |
29.32195036143923 ns/iter |
1.00 |
Evaluator_Draft4_Pattern_Properties_True |
238.27021763861092 ns/iter |
245.3023817405794 ns/iter |
0.97 |
Evaluator_Draft4_Ref_To_Single_Property |
17.211689442348455 ns/iter |
17.1516540547378 ns/iter |
1.00 |
Evaluator_Draft4_Additional_Properties_Type |
53.78239821025819 ns/iter |
53.621392073714006 ns/iter |
1.00 |
Evaluator_Draft4_Nested_Oneof |
88.9257217046555 ns/iter |
89.29617826249533 ns/iter |
1.00 |
Evaluator_Draft4_Long_Enum |
19.608863319682758 ns/iter |
20.550981326099215 ns/iter |
0.95 |
Evaluator_Draft4_Type_Object |
10.575541876869796 ns/iter |
10.6041830708104 ns/iter |
1.00 |
Evaluator_Draft6_Property_Names |
143.66516185234713 ns/iter |
143.9681223107722 ns/iter |
1.00 |
Evaluator_Draft7_If_Then_Else |
41.049223539823636 ns/iter |
41.723531327272404 ns/iter |
0.98 |
Evaluator_Draft7_Vercel_1 |
48526.038790130064 ns/iter |
50996.27910000209 ns/iter |
0.95 |
Evaluator_Draft7_Helm_Chart_Lock_1 |
334.3522776549924 ns/iter |
312.44409393509284 ns/iter |
1.07 |
Evaluator_Draft7_Jasmine_1 |
171.72359280188817 ns/iter |
167.65849636791737 ns/iter |
1.02 |
Evaluator_2019_09_Unevaluated_Properties |
51.07012019262498 ns/iter |
55.37549707740827 ns/iter |
0.92 |
Evaluator_2019_09_OMC_JSON_V2_1 |
1354.3497388083754 ns/iter |
1374.441400500827 ns/iter |
0.99 |
Evaluator_2020_12_Dynamic_Ref |
583.4561337397672 ns/iter |
573.0724245652073 ns/iter |
1.02 |
Evaluator_2020_12_Dynamic_Ref_Single |
10.581890220106066 ns/iter |
10.587087957616955 ns/iter |
1.00 |
Evaluator_2020_12_CQL_1 |
4029.1785393653545 ns/iter |
4024.002108610439 ns/iter |
1.00 |
Evaluator_2020_12_OpenAPI |
184998.1396287337 ns/iter |
179921.01462664377 ns/iter |
1.03 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (macos/llvm)
Benchmark suite | Current: 5edc81a | Previous: 5b88c12 | Ratio |
---|---|---|---|
Compiler_Draft6_AdaptiveCard |
38431841042.000084 ns/iter |
44744585333.00003 ns/iter |
0.86 |
Compiler_2019_09_OMC_JSON_V2 |
7511588374.999974 ns/iter |
8899947042.000122 ns/iter |
0.84 |
Evaluator_Draft4_Meta_1_No_Callback |
169.93627480111903 ns/iter |
182.13576081614897 ns/iter |
0.93 |
Evaluator_Draft4_Required_Properties |
449.2431726167696 ns/iter |
496.74187828513806 ns/iter |
0.90 |
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match |
21.671671749113514 ns/iter |
27.54210216597327 ns/iter |
0.79 |
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match |
9.306010644615714 ns/iter |
10.397237662071305 ns/iter |
0.90 |
Evaluator_Draft4_Items_Schema |
255.78599861928996 ns/iter |
295.93413623912477 ns/iter |
0.86 |
Evaluator_Draft4_Nested_Object |
3.222821745674574 ns/iter |
3.5453630039981125 ns/iter |
0.91 |
Evaluator_Draft4_Properties_Triad_Optional |
751.8842331221314 ns/iter |
825.5326697182028 ns/iter |
0.91 |
Evaluator_Draft4_Properties_Triad_Closed |
632.6303575041807 ns/iter |
680.4971834435947 ns/iter |
0.93 |
Evaluator_Draft4_Properties_Triad_Required |
848.98638300614 ns/iter |
835.1310584810813 ns/iter |
1.02 |
Evaluator_Draft4_Properties_Closed |
48.493422918909296 ns/iter |
53.15690288697279 ns/iter |
0.91 |
Evaluator_Draft4_Non_Recursive_Ref |
9.757931729047794 ns/iter |
10.457278046414682 ns/iter |
0.93 |
Evaluator_Draft4_Pattern_Properties_True |
160.94751888623188 ns/iter |
179.0147928687997 ns/iter |
0.90 |
Evaluator_Draft4_Ref_To_Single_Property |
9.41767002412937 ns/iter |
10.189910159776819 ns/iter |
0.92 |
Evaluator_Draft4_Additional_Properties_Type |
15.952713929007478 ns/iter |
17.070018959987394 ns/iter |
0.93 |
Evaluator_Draft4_Nested_Oneof |
49.636402206490565 ns/iter |
57.86081337841906 ns/iter |
0.86 |
Evaluator_Draft4_Long_Enum |
26.59033774391072 ns/iter |
31.087729117120432 ns/iter |
0.86 |
Evaluator_Draft4_Type_Object |
5.357319358077746 ns/iter |
5.948384202209474 ns/iter |
0.90 |
Evaluator_Draft6_Property_Names |
85.37576470175412 ns/iter |
93.93102536423102 ns/iter |
0.91 |
Evaluator_Draft7_If_Then_Else |
24.58442362208465 ns/iter |
26.416338618997308 ns/iter |
0.93 |
Evaluator_Draft7_Vercel_1 |
34096.37882283559 ns/iter |
37310.82132869788 ns/iter |
0.91 |
Evaluator_Draft7_Helm_Chart_Lock_1 |
142.07958024346593 ns/iter |
155.41496923508768 ns/iter |
0.91 |
Evaluator_Draft7_Jasmine_1 |
121.4473446011571 ns/iter |
139.46129201983138 ns/iter |
0.87 |
Evaluator_2019_09_Unevaluated_Properties |
34.91393525275073 ns/iter |
37.02515034802034 ns/iter |
0.94 |
Evaluator_2019_09_OMC_JSON_V2_1 |
1027.1160626914605 ns/iter |
1070.3311706603045 ns/iter |
0.96 |
Evaluator_2020_12_Dynamic_Ref |
363.36036196050884 ns/iter |
402.3871296734391 ns/iter |
0.90 |
Evaluator_2020_12_Dynamic_Ref_Single |
5.331588987155928 ns/iter |
6.078152299660698 ns/iter |
0.88 |
Evaluator_2020_12_CQL_1 |
2411.2123772575424 ns/iter |
2352.981248039982 ns/iter |
1.02 |
Evaluator_2020_12_OpenAPI |
158327.26107423333 ns/iter |
151142.1965428977 ns/iter |
1.05 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (macos/gcc)
Benchmark suite | Current: 5edc81a | Previous: 5b88c12 | Ratio |
---|---|---|---|
Compiler_Draft6_AdaptiveCard |
48993700027.46582 ns/iter |
48546916007.995605 ns/iter |
1.01 |
Compiler_2019_09_OMC_JSON_V2 |
8523983955.383301 ns/iter |
7747501134.872437 ns/iter |
1.10 |
Evaluator_Draft4_Meta_1_No_Callback |
177.43571635866954 ns/iter |
159.47080985448122 ns/iter |
1.11 |
Evaluator_Draft4_Required_Properties |
410.4961902255753 ns/iter |
373.29723128106724 ns/iter |
1.10 |
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match |
19.063894304236083 ns/iter |
16.934580263445923 ns/iter |
1.13 |
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match |
10.299848106678345 ns/iter |
9.1253782998132 ns/iter |
1.13 |
Evaluator_Draft4_Items_Schema |
497.854587259339 ns/iter |
433.3781133353307 ns/iter |
1.15 |
Evaluator_Draft4_Nested_Object |
2.1305409972484695 ns/iter |
2.03009470158711 ns/iter |
1.05 |
Evaluator_Draft4_Properties_Triad_Optional |
871.5230020628196 ns/iter |
774.1304102478814 ns/iter |
1.13 |
Evaluator_Draft4_Properties_Triad_Closed |
693.9311421642545 ns/iter |
682.7063620703661 ns/iter |
1.02 |
Evaluator_Draft4_Properties_Triad_Required |
865.0631451683732 ns/iter |
794.9107875043085 ns/iter |
1.09 |
Evaluator_Draft4_Properties_Closed |
68.28354346722558 ns/iter |
63.88194256057544 ns/iter |
1.07 |
Evaluator_Draft4_Non_Recursive_Ref |
13.945019098734308 ns/iter |
12.813509169404776 ns/iter |
1.09 |
Evaluator_Draft4_Pattern_Properties_True |
182.9868765259133 ns/iter |
180.8932887977582 ns/iter |
1.01 |
Evaluator_Draft4_Ref_To_Single_Property |
9.506687112576866 ns/iter |
9.169334652796014 ns/iter |
1.04 |
Evaluator_Draft4_Additional_Properties_Type |
26.76511373809386 ns/iter |
24.062175865278746 ns/iter |
1.11 |
Evaluator_Draft4_Nested_Oneof |
59.595848589077185 ns/iter |
54.10344880684363 ns/iter |
1.10 |
Evaluator_Draft4_Long_Enum |
9.263029301680545 ns/iter |
8.560913505481302 ns/iter |
1.08 |
Evaluator_Draft4_Type_Object |
4.903728945920202 ns/iter |
4.514658261065234 ns/iter |
1.09 |
Evaluator_Draft6_Property_Names |
129.13039204206578 ns/iter |
109.64854167067898 ns/iter |
1.18 |
Evaluator_Draft7_If_Then_Else |
27.47637513912751 ns/iter |
25.582544009889087 ns/iter |
1.07 |
Evaluator_Draft7_Vercel_1 |
41302.10958750041 ns/iter |
36699.493275378 ns/iter |
1.13 |
Evaluator_Draft7_Helm_Chart_Lock_1 |
208.86730305357332 ns/iter |
192.07929856145753 ns/iter |
1.09 |
Evaluator_Draft7_Jasmine_1 |
135.1381226276974 ns/iter |
121.2008210286188 ns/iter |
1.11 |
Evaluator_2019_09_Unevaluated_Properties |
36.18669834495497 ns/iter |
33.47637076471766 ns/iter |
1.08 |
Evaluator_2019_09_OMC_JSON_V2_1 |
987.5963972965569 ns/iter |
995.9533807519443 ns/iter |
0.99 |
Evaluator_2020_12_Dynamic_Ref |
440.19521858642 ns/iter |
442.38394362818383 ns/iter |
1.00 |
Evaluator_2020_12_Dynamic_Ref_Single |
4.526384915310447 ns/iter |
4.510693145984732 ns/iter |
1.00 |
Evaluator_2020_12_CQL_1 |
2617.0937854601443 ns/iter |
2652.9995226423134 ns/iter |
0.99 |
Evaluator_2020_12_OpenAPI |
159083.4252789233 ns/iter |
159032.93206932597 ns/iter |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (linux/gcc)
Benchmark suite | Current: 5edc81a | Previous: 5b88c12 | Ratio |
---|---|---|---|
Evaluator_2020_12_Dynamic_Ref |
628.351894379961 ns/iter |
618.9685646188258 ns/iter |
1.02 |
Evaluator_2020_12_Dynamic_Ref_Single |
9.323539422208057 ns/iter |
9.607808168697758 ns/iter |
0.97 |
Evaluator_2020_12_CQL_1 |
4231.764806866824 ns/iter |
4150.203448195596 ns/iter |
1.02 |
Evaluator_2020_12_OpenAPI |
238369.0749579613 ns/iter |
229329.4566721622 ns/iter |
1.04 |
Evaluator_2019_09_Unevaluated_Properties |
55.11616500078658 ns/iter |
51.75212524205327 ns/iter |
1.07 |
Evaluator_2019_09_OMC_JSON_V2_1 |
1377.3052931096588 ns/iter |
1336.3812690544025 ns/iter |
1.03 |
Evaluator_Draft7_If_Then_Else |
43.54834457136327 ns/iter |
42.72926045359184 ns/iter |
1.02 |
Evaluator_Draft7_Vercel_1 |
45326.57681555193 ns/iter |
44414.67355480051 ns/iter |
1.02 |
Evaluator_Draft7_Helm_Chart_Lock_1 |
198.7420265880239 ns/iter |
199.979668264501 ns/iter |
0.99 |
Evaluator_Draft7_Jasmine_1 |
153.83406897967845 ns/iter |
149.09041054101212 ns/iter |
1.03 |
Evaluator_Draft6_Property_Names |
153.3517585619378 ns/iter |
146.18810891972444 ns/iter |
1.05 |
Evaluator_Draft4_Meta_1_No_Callback |
229.16719996230975 ns/iter |
229.4203657390148 ns/iter |
1.00 |
Evaluator_Draft4_Required_Properties |
449.38870812636173 ns/iter |
428.11480467272753 ns/iter |
1.05 |
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match |
25.64042438602997 ns/iter |
25.94818479488603 ns/iter |
0.99 |
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match |
11.895055498961755 ns/iter |
12.180208329868043 ns/iter |
0.98 |
Evaluator_Draft4_Items_Schema |
495.0262499328998 ns/iter |
493.8079408561685 ns/iter |
1.00 |
Evaluator_Draft4_Nested_Object |
4.346640478601948 ns/iter |
3.8472909806513194 ns/iter |
1.13 |
Evaluator_Draft4_Properties_Triad_Optional |
1029.619379724566 ns/iter |
1022.6798229943288 ns/iter |
1.01 |
Evaluator_Draft4_Properties_Triad_Closed |
810.3746980677089 ns/iter |
805.0151104178493 ns/iter |
1.01 |
Evaluator_Draft4_Properties_Triad_Required |
1032.4866651043483 ns/iter |
1044.9451325390621 ns/iter |
0.99 |
Evaluator_Draft4_Properties_Closed |
72.55790237819555 ns/iter |
75.2972799885279 ns/iter |
0.96 |
Evaluator_Draft4_Non_Recursive_Ref |
12.213254434790013 ns/iter |
12.46328148907794 ns/iter |
0.98 |
Evaluator_Draft4_Pattern_Properties_True |
263.5740264832785 ns/iter |
284.1515017333955 ns/iter |
0.93 |
Evaluator_Draft4_Ref_To_Single_Property |
11.905742801887795 ns/iter |
12.15205049520589 ns/iter |
0.98 |
Evaluator_Draft4_Additional_Properties_Type |
14.711873372991649 ns/iter |
15.282329952040474 ns/iter |
0.96 |
Evaluator_Draft4_Nested_Oneof |
107.4972316035913 ns/iter |
106.8402839133867 ns/iter |
1.01 |
Evaluator_Draft4_Long_Enum |
18.196969609543167 ns/iter |
18.138764511892006 ns/iter |
1.00 |
Evaluator_Draft4_Type_Object |
9.27184753139914 ns/iter |
9.598015113482587 ns/iter |
0.97 |
Compiler_2019_09_OMC_JSON_V2 |
10489351917.000021 ns/iter |
10298627600.000032 ns/iter |
1.02 |
Compiler_Draft6_AdaptiveCard |
59289053603.00007 ns/iter |
59201795691.00003 ns/iter |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark (windows/msvc)
Benchmark suite | Current: 5edc81a | Previous: 5b88c12 | Ratio |
---|---|---|---|
Compiler_Draft6_AdaptiveCard |
136863632000.00005 ns/iter |
139752890100.00006 ns/iter |
0.98 |
Compiler_2019_09_OMC_JSON_V2 |
22737634799.999798 ns/iter |
22771356500.000137 ns/iter |
1.00 |
Evaluator_Draft4_Meta_1_No_Callback |
351.22433934038844 ns/iter |
355.39385961570474 ns/iter |
0.99 |
Evaluator_Draft4_Required_Properties |
1022.4182935629998 ns/iter |
911.5727626906423 ns/iter |
1.12 |
Evaluator_Draft4_Many_Optional_Properties_Minimal_Match |
38.17311896119223 ns/iter |
38.658556452531386 ns/iter |
0.99 |
Evaluator_Draft4_Few_Optional_Properties_Minimal_Match |
21.23883437499785 ns/iter |
21.120634374995007 ns/iter |
1.01 |
Evaluator_Draft4_Items_Schema |
702.8271205357888 ns/iter |
696.2950892857732 ns/iter |
1.01 |
Evaluator_Draft4_Nested_Object |
6.614364955357388 ns/iter |
6.517644642857232 ns/iter |
1.01 |
Evaluator_Draft4_Properties_Triad_Optional |
1619.7868303576358 ns/iter |
1679.669419642847 ns/iter |
0.96 |
Evaluator_Draft4_Properties_Triad_Closed |
1311.9705973343994 ns/iter |
1386.4355194486882 ns/iter |
0.95 |
Evaluator_Draft4_Properties_Triad_Required |
1653.3310580371779 ns/iter |
1711.9340098654895 ns/iter |
0.97 |
Evaluator_Draft4_Properties_Closed |
94.613942204746 ns/iter |
94.45001364062323 ns/iter |
1.00 |
Evaluator_Draft4_Non_Recursive_Ref |
32.2369107142809 ns/iter |
32.285114566954704 ns/iter |
1.00 |
Evaluator_Draft4_Pattern_Properties_True |
234.02461673835595 ns/iter |
220.5756115428618 ns/iter |
1.06 |
Evaluator_Draft4_Ref_To_Single_Property |
21.245714570255736 ns/iter |
21.395818750001183 ns/iter |
0.99 |
Evaluator_Draft4_Additional_Properties_Type |
57.591383928569584 ns/iter |
57.80558999999812 ns/iter |
1.00 |
Evaluator_Draft4_Nested_Oneof |
106.75545312501811 ns/iter |
108.76862499998197 ns/iter |
0.98 |
Evaluator_Draft4_Long_Enum |
22.404143750001992 ns/iter |
23.370193935599154 ns/iter |
0.96 |
Evaluator_Draft4_Type_Object |
13.061885714287362 ns/iter |
13.021714285713415 ns/iter |
1.00 |
Evaluator_Draft6_Property_Names |
166.84955357142428 ns/iter |
173.3967928613745 ns/iter |
0.96 |
Evaluator_Draft7_If_Then_Else |
50.58077000001049 ns/iter |
52.58977999999388 ns/iter |
0.96 |
Evaluator_Draft7_Vercel_1 |
79149.41964285914 ns/iter |
74685.92857143059 ns/iter |
1.06 |
Evaluator_Draft7_Helm_Chart_Lock_1 |
327.7946762178357 ns/iter |
318.62700892862756 ns/iter |
1.03 |
Evaluator_Draft7_Jasmine_1 |
238.53857142861605 ns/iter |
224.8142812499765 ns/iter |
1.06 |
Evaluator_2019_09_Unevaluated_Properties |
60.00994642858716 ns/iter |
58.20399000001544 ns/iter |
1.03 |
Evaluator_2019_09_OMC_JSON_V2_1 |
1905.1854510579353 ns/iter |
1897.5333013690772 ns/iter |
1.00 |
Evaluator_2020_12_Dynamic_Ref |
853.4147082971413 ns/iter |
825.8546874999288 ns/iter |
1.03 |
Evaluator_2020_12_Dynamic_Ref_Single |
12.794373214286939 ns/iter |
12.994348214285926 ns/iter |
0.98 |
Evaluator_2020_12_CQL_1 |
4829.441583573975 ns/iter |
4793.190386586008 ns/iter |
1.01 |
Evaluator_2020_12_OpenAPI |
288711.068702296 ns/iter |
287729.16834064724 ns/iter |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
e15a07f
to
e04d3c2
Compare
Signed-off-by: Juan Cruz Viotti <[email protected]>
e04d3c2
to
5edc81a
Compare
Signed-off-by: Juan Cruz Viotti [email protected]