Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MinHash implementations (many shared methods) #1055

Open
luizirber opened this issue Jun 27, 2020 · 3 comments
Open

Refactor MinHash implementations (many shared methods) #1055

luizirber opened this issue Jun 27, 2020 · 3 comments
Labels

Comments

@luizirber
Copy link
Member

The B-Tree impl in #1045 is a copy-paste-fix from the Vec impl. There is opportunity for refactoring and sharing most of the methods. Define a MinOps trait with what methods should be implemented, and add default impls when possible.

(punted from #1045 (comment))

@ctb
Copy link
Contributor

ctb commented Aug 9, 2020

this is another good first issue for people interested in getting into Rust, but it would need more description to be truly approachable, I think.

@ctb
Copy link
Contributor

ctb commented Sep 23, 2023

hi @luizirber still relevant?

Copy link
Member Author

Yup, in #2728

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants