Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider adjusting search --threshold default value and how -n works #2169

Open
ctb opened this issue Aug 2, 2022 · 3 comments
Open

consider adjusting search --threshold default value and how -n works #2169

ctb opened this issue Aug 2, 2022 · 3 comments
Labels
5.0 issues to address for a 5.0 release
Milestone

Comments

@ctb
Copy link
Contributor

ctb commented Aug 2, 2022

see #2168 - a few ideas:

  • remove -n completely, 'cause it's a bit silly;
  • increase -n to be something larger than three;
  • adjust docstring for -n to point at --threshold
  • have -n lower threshold automatically;
@ctb ctb added the 5.0 issues to address for a 5.0 release label Aug 2, 2022
@ctb
Copy link
Contributor Author

ctb commented Aug 2, 2022

also ref #2002

@ctb ctb changed the title consider adjust search --threshold default value/how -n works consider adjusting search --threshold default value and how -n works Aug 2, 2022
@ctb
Copy link
Contributor Author

ctb commented Aug 2, 2022

see also #1914

@ctb
Copy link
Contributor Author

ctb commented Aug 18, 2022

Addressed this a bit, and fixed #1914, in #2222. I think #2002 is a good long-term future for search, tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 issues to address for a 5.0 release
Projects
None yet
Development

No branches or pull requests

2 participants