suspend cores while waiting #3
Open
+9
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build for testing: |
|
Build for testing: |
soyersoyer
changed the title
It works with WaitForEvent, without disabling IRQs. Before this the WaitForInterrupt was used, and these findigs were useful: Before checking the atomic variable, disable IRQs to avoid missing the wake-up event. https://marc.info/?l=linux-arm-kernel&m=114684008423863&w=2 https://electronics.stackexchange.com/questions/12601/best-pattern-for-wfi-wait-for-interrupt-on-cortex-arm-microcontrolers add dsb before wfi torvalds/linux@8553cb6 https://github.com/torvalds/linux/blob/master/arch/arm/mm/proc-v7.S https://github.com/torvalds/linux/blob/master/arch/arm64/kernel/idle.c torvalds/linux@9cce7a4
|
Build for testing: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It uses the WaitForEvent and SendIPI functions to signal between cores to sleep and wakeup.
I tested it with an USB power meter:
RPI3b+ with MiniLab 3
latest: 2.29W (idle)
this: 1.91W (idle)
RPI4 with MiniLab 3
latest: 2.81W (idle) 3.2W (play)
this: 2.45W (idle) 2.82W (play)
I tested it for two days, it worked without any problems.