You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This should rather return an anyhow::Result<()> with context, to be handled downstream.
Feel free to comment below on where this change should be applied (or not applied), with github permalinks. Also, quote this issue in ongoing pull requests.
The text was updated successfully, but these errors were encountered:
It seems enough for now. It has gotten too far, even. In the future, we may prefer to use custom Errors in each module and use thiserror instead of anyhow.
As discovered in this Pull Request:
Errors are too often logged in the middle of low-level functions, when they should rather get trickled up and logged by the logic calling them.
A good example is in
command/src/channel.rs
:sozu/command/src/channel.rs
Lines 119 to 132 in 68e3859
This should rather return an
anyhow::Result<()>
with context, to be handled downstream.Feel free to comment below on where this change should be applied (or not applied), with github permalinks. Also, quote this issue in ongoing pull requests.
The text was updated successfully, but these errors were encountered: