error propagation on HTTP and HTTPS frontend add and remove #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keksoj
force-pushed
the
error_propagating_on_http_listener
branch
from
02f3582
to
036505c
Compare
|
merge #861 first, and then rebase this |
FlorentinDUBOIS
requested changes
Dec 7, 2022
Keksoj
force-pushed
the
error_propagating_on_http_listener
branch
from
036505c
to
03085ea
Compare
|
At last, it is ready for review and merge @FlorentinDUBOIS ;-) |
FlorentinDUBOIS
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the spirit of #825 , we prefer one-line context-full errors logs instead of several lines apart from one another.
This PR adds error propagation to HTTP and HTTPS frontend adding & removing logic.