Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics option: no-clusters #1032

Merged
merged 1 commit into from
Jan 24, 2024
Merged

metrics option: no-clusters #1032

merged 1 commit into from
Jan 24, 2024

Conversation

Keksoj
Copy link
Member

@Keksoj Keksoj commented Nov 20, 2023

With the introduction of histogram metrics (#1005) and the overall number of metrics, it will be usefull to opt out of querying-receiving-displaying cluster metrics, to focus on main process and worker metrics only.

This pull request introduces:

  • an only_workers field on the protobuf QueryMetricsOption object. The sozu-prometheus-connector and other tools will thus be able to fetch only main process & worker metrics if needed
    a --workers option on the metrics get command in the CLI

@Keksoj Keksoj added this to the v0.16.0 milestone Nov 20, 2023
@Keksoj Keksoj self-assigned this Nov 20, 2023
@Keksoj Keksoj force-pushed the fix-display-in-json-form branch 2 times, most recently from f0ba2cd to 88fb8cb Compare November 27, 2023 14:19
@Keksoj Keksoj changed the base branch from fix-display-in-json-form to main November 29, 2023 14:00
@Keksoj Keksoj force-pushed the only-worker-metrics-option branch 2 times, most recently from 5ada5f3 to dd17f93 Compare January 24, 2024 10:05
@Keksoj Keksoj changed the title metrics option: only-worker metrics option: no-clusters Jan 24, 2024
@Keksoj Keksoj merged commit 5e30411 into main Jan 24, 2024
13 checks passed
@Keksoj Keksoj deleted the only-worker-metrics-option branch February 8, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants