Retry connection with the backend of access logs

bin/src/command/mod.rs

@@ -11,7 +11,7 @@ use mio::net::UnixListener;
 
 use sozu_command_lib::{
     config::{Config, ConfigError},
-    logging::setup_logging_with_config,
+    logging::{setup_logging_with_config, LogError},
 };
 
 use crate::{
@@ -52,14 +52,16 @@ pub enum StartError {
     SetPermissions(IoError),
     #[error("could not launch new worker: {0}")]
     LaunchWorker(ServerError),
+    #[error("could not setup the logger: {0}")]
+    SetupLogging(LogError),
 }
 
 pub fn begin_main_process(args: &Args) -> Result<(), StartError> {
     let config_file_path = get_config_file_path(args).map_err(StartError::GetConfigPath)?;
 
     let config = Config::load_from_path(config_file_path).map_err(StartError::LoadConfig)?;
 
-    setup_logging_with_config(&config, "MAIN");
+    setup_logging_with_config(&config, "MAIN").map_err(StartError::SetupLogging)?;
     info!("Starting up");
     setup_metrics(&config).map_err(StartError::SetupMetrics)?;
     write_pid_file(&config).map_err(StartError::WritePidFile)?;

bin/src/ctl/command.rs

@@ -162,7 +162,11 @@ impl CommandManager {
             let config = self.config.clone();
 
             upgrade_jobs.push(std::thread::spawn(move || {
-                setup_logging_with_config(&config, &format!("UPGRADE-WRK-{}", worker.id));
+                if let Err(e) =
+                    setup_logging_with_config(&config, &format!("UPGRADE-WRK-{}", worker.id))
+                {
+                    error!("Could not setup logging: {}", e);
+                }
 
                 info!("creating channel to upgrade worker {}", worker.id);
                 let channel = match create_channel(&config) {

bin/src/ctl/mod.rs

@@ -7,7 +7,7 @@ use sozu_command_lib::{
     certificate::CertificateError,
     channel::{Channel, ChannelError},
     config::{Config, ConfigError},
-    logging::setup_logging_with_config,
+    logging::{setup_logging_with_config, LogError},
     proto::{
         command::{Request, Response},
         DisplayError,
@@ -53,6 +53,8 @@ pub enum CtlError {
     NeedClusterDomain,
     #[error("wrong response from Sōzu: {0:?}")]
     WrongResponse(Response),
+    #[error("could not setup the logger: {0}")]
+    SetupLogging(LogError),
 }
 
 pub struct CommandManager {
@@ -70,7 +72,7 @@ pub fn ctl(args: cli::Args) -> Result<(), CtlError> {
 
     // prevent logging for json responses for a clean output
     if !args.json {
-        setup_logging_with_config(&config, "CTL");
+        setup_logging_with_config(&config, "CTL").map_err(CtlError::SetupLogging)?;
     }
 
     // If the command is `config check` then exit because if we are here, the configuration is valid

bin/src/upgrade.rs

@@ -18,7 +18,7 @@ use tempfile::tempfile;
 
 use sozu_command_lib::{
     channel::{Channel, ChannelError},
-    logging::setup_logging_with_config,
+    logging::{setup_logging_with_config, LogError},
 };
 
 use crate::{
@@ -69,6 +69,8 @@ pub enum UpgradeError {
     CreateHub(HubError),
     #[error("could not enable cloexec after upgrade: {0}")]
     EnableCloexec(ServerError),
+    #[error("could not setup the logger: {0}")]
+    SetupLogging(LogError),
 }
 
 /// unix-forks the main process
@@ -180,7 +182,7 @@ pub fn begin_new_main_process(
 
     println!("Setting up logging");
 
-    setup_logging_with_config(&config, "MAIN");
+    setup_logging_with_config(&config, "MAIN").map_err(UpgradeError::SetupLogging)?;
     util::setup_metrics(&config).map_err(UpgradeError::SetupMetrics)?;
 
     let mut command_hub =

bin/src/worker.rs

@@ -22,7 +22,7 @@ use tempfile::tempfile;
 use sozu_command_lib::{
     channel::{Channel, ChannelError},
     config::Config,
-    logging::{setup_logging, AccessLogFormat},
+    logging::{setup_logging, AccessLogFormat, LogError},
     proto::command::{ServerConfig, WorkerRequest, WorkerResponse},
     ready::Ready,
     request::{read_initial_state_from_file, RequestError},
@@ -74,6 +74,8 @@ pub enum WorkerError {
         state: String,
         channel_err: ChannelError,
     },
+    #[error("could not setup the logger: {0}")]
+    SetupLogging(LogError),
 }
 
 /// called within a worker process, this starts the actual proxy
@@ -117,7 +119,8 @@ pub fn begin_worker_process(
         Some(worker_config.log_colored),
         &worker_config.log_level,
         &worker_id,
-    );
+    )
+    .map_err(WorkerError::SetupLogging)?;
 
     trace!(
         "Creating worker {} with config: {:#?}",

command/examples/bench_logger.rs

@@ -53,7 +53,9 @@ fn main() {
     eprintln!(
         "n={n}, pre_generate={pre_generate}, target={target}, colored={colored}, filter={filter}"
     );
-    setup_logging(&target, colored, None, None, None, &filter, "WRK-01");
+    if let Err(e) = setup_logging(&target, colored, None, None, None, &filter, "WRK-01") {
+        println!("could not setup logging: {}", e);
+    }
 
     let mut pre_generated_log_iterator;
     let mut log_iterator = std::iter::repeat(())

command/src/config.rs

@@ -172,6 +172,9 @@ pub const MAX_LOOP_ITERATIONS: usize = 100000;
 /// with little influence on performance. Defaults to 4.
 pub const DEFAULT_SEND_TLS_13_TICKETS: u64 = 4;
 
+/// for both logs and access logs
+pub const DEFAULT_LOG_TARGET: &str = "stdout";
+
 #[derive(Debug)]
 pub enum IncompatibilityKind {
     PublicAddress,