add request_time metric to access logs, BREAKING CHANGE #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorentinDUBOIS
previously requested changes
Jun 25, 2024
Keksoj
force-pushed
the
add-request-time-metric
branch
from
0a7588c
to
21a6c33
Compare
Keksoj
force-pushed
the
add-request-time-metric
branch
from
21a6c33
to
122716a
Compare
fix the response_time metric, request_time was wrongly assigned to it instead, response_time is assigned the value of backend_response_time Co-Authored-By: Eloi DEMOLIS <[email protected]>
Keksoj
force-pushed
the
add-request-time-metric
branch
from
122716a
to
57923de
Compare
Keksoj
dismissed
FlorentinDUBOIS’s stale review
I applied the change, and it was approved by @llenotre
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #1112, there was no
request_timemetric available (time between first byte received and last byte sent).The value was computed, but wrongly assigned to the
response_timemetric.This PR fixes it, and now,
response_timehas a better meaning and accurate value: the time between connecting to the backend and finishing the response.We could even rename
request_timeto a more fittingsession_time.