Refine granularity of 400 and 502 error diagnostics #1151
+183
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wonshtrum
requested review from
FlorentinDUBOIS,
Keksoj and
llenotre
as code owners
Wonshtrum
force-pushed
the
answer-granularity
branch
2 times, most recently
from
e65c9c1
to
bb7535f
Compare
|
should solve #1150 |
Wonshtrum
force-pushed
the
answer-granularity
branch
2 times, most recently
from
18ada37
to
1f2b2b1
Compare
Signed-off-by: Eloi DEMOLIS <[email protected]>
Wonshtrum
force-pushed
the
answer-granularity
branch
from
1f2b2b1
to
07c7ec0
Compare
Keksoj
approved these changes
Nov 7, 2024
| format!("The first {marker} is invalid, make sure {CHARSET}.") | ||
| } | ||
| format!("A {marker} is invalid, make sure {CHARSET}.") | ||
| // if let Some(Block::Header(Pair { key, .. })) = kawa.blocks.back() { |
There was a problem hiding this comment.
maybe delete these lines entirely?
| } else { | ||
| format!("The first cookie is invalid, make sure {CHARSET}.") | ||
| } | ||
| // if kawa.detached.jar.len() > 1 { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1143 and #1150.
This splits the
DETAILSvariable of errors 400 and 502 into 3 hexadecimal buffersSUCCESSFULLY_PARSED,PARTIALLY_PARSED, andINVALID. This avoids any XSS attacks from this variable. The last valid header/trailer/cookie has also been removed fromMESSAGE.The new 400 and 502 use JavaScript to display the hexadecimal buffers as utf-8 (using the safe
innerText) and hopefully help the client fix the problem: