remove skipping of certificate update in GenericCertificateResolver #988
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by @justinkb, @newdev8 and others in this issue: #774 , those lines in the
add_certificate
method of the GenericCertificateResolver prevent persisting several subdomains:Removing these lines do not break any test, as the CI on this Pull Request should prove, and according to @justinkb, does solve the issue.
The best would be to have an e2e test for this behaviour with several subdomains. What do you think @Wonshtrum ?