Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove skipping of certificate update in GenericCertificateResolver #988

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

Keksoj
Copy link
Member

@Keksoj Keksoj commented Sep 11, 2023

As pointed out by @justinkb, @newdev8 and others in this issue: #774 , those lines in the add_certificate method of the GenericCertificateResolver prevent persisting several subdomains:

        // We do not need to update the entry, if the certificate is already registered
        if self.get_certificate(&fingerprint).is_some() {
            return Ok(fingerprint);
        }

Removing these lines do not break any test, as the CI on this Pull Request should prove, and according to @justinkb, does solve the issue.

The best would be to have an e2e test for this behaviour with several subdomains. What do you think @Wonshtrum ?

@FlorentinDUBOIS FlorentinDUBOIS merged commit bf7b492 into main Sep 12, 2023
12 checks passed
@FlorentinDUBOIS FlorentinDUBOIS deleted the fix-issue-774 branch September 12, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants