Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NASA Challenge_[franklinselva]_[IsaacSim Integration for Curiosity Rover demo] #34

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

franklinselva
Copy link

@franklinselva franklinselva commented Aug 27, 2024

The purpose of this PR is to provide IsaacSim Integration with the demos repository.

Depends on #31
Blocked by space-ros/simulation#21

Merge queue 3

The main changes in this PR include,

  • The demo repository of curiosity rover is restructured to the diagram represented below
  • Both the simulation interfaces are supported (gazebosim and isaacsim). This allows the demos to be reproducible in both the interfaces
  • The use of Makefile is simpler for spinning off the demos in both the simulations.
  • The documentation to run demos in both the environments has been updated
graph LR
    A[GazeboSim] <--> B[Ignition ROS2]
    B <--ROS2 control--> C[Common Package]
    C <--> D[Demo Packages]
    D <--> E[Space ROS2]

    C <--Isaac ROS2 Bridge--> F[Isaac Sim ROS2 Extension]
    F <--> G[Isaac Sim]


    subgraph Host Machine - GazeboSim
        A
        B
    end

    subgraph Host Machine - Isaac Sim
        F
        G
    end

    subgraph Space ROS Container
        C
        D
        E
    end
Loading

Note for reviewers: This PR is not meant to be large and the blocker item needs to be merged first to tackle the problem.

resolves #178

- Group demos to its robot content
resolves space-ros/space-ros#178

 - Add canadarm_description
 - Fix model asset paths
 - Reverse control configuration for canadarm model
resolves space-ros/space-ros#178
 - Add curiosity_description
 - Strip third party dependencies of mars_rover
resolves space-ros/space-ros#178

 - Fix control parameters for curiosity_description
 - Move curiosity_path world to curiosity_gazebo
 - Add launch file for spinning of gazebo world
related to space-ros/space-ros#178
 - Cleaned up rover launch file for the demo
 - Updated comments for demo node
related to space-ros/space-ros#178

 - Add dockerfile for demo
 - Add makefile for build, run and clean automation
related to space-ros/space-ros#178

 - Add README.md for Curiosity Rover demo
 - Update Main README.md of the demos repository
resolves space-ros/space-ros#178

 - Add canadarm_description package
 - Move earth and iss  world models to canadarm_gazebo
related to space-ros/space-ros#178
 - Cleaned up canadarm launch file for the demo
 - Updated comments for demo node
 - Strip Moveit Redundant Node
 - Cleanup packages.xml
 - Remove ros control parameters for gazebo
related to space-ros/space-ros#178

 - Add README.md for Canadarm2 demo
 - Update Main README.md of the demos repository
Related to space-ros/space-ros#178

 - Update package.xml for canadarm2 packages
 - Update package.xml for curiosity_rover packages
Related to space-ros/space-ros#178

 - Remove makefiles for canadarm2 and curiosity rover demo
 - Add build.sh for building canadarm2 and curiosity rover demo
 - Add run.sh for running the demos
 - Update README.md of demos to the new process
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant