Add a method in SharedTransformSystem for swapping the position of two entities #4988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Robust.Shared/GameObjects/Systems/SharedTransformSystem.Component.cs
Outdated
Show resolved
Hide resolved
Robust.Shared/GameObjects/Systems/SharedTransformSystem.Component.cs
Outdated
Show resolved
Hide resolved
Robust.Shared/GameObjects/Systems/SharedTransformSystem.Component.cs
Outdated
Show resolved
Hide resolved
metalgearsloth
requested changes
Mar 24, 2024
Robust.Shared/GameObjects/Systems/SharedTransformSystem.Component.cs
Outdated
Show resolved
Hide resolved
Robust.Shared/GameObjects/Systems/SharedTransformSystem.Component.cs
Outdated
Show resolved
Hide resolved
metalgearsloth
requested changes
Apr 14, 2024
… into swap-positions-method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Common content pattern that breaks frequently due to oversights (using entity coordinates, not respecting containers, etc)
The method simply takes two entities and swaps their world positions, moving them across maps. This hopefully will reduce issues in content where bad transform calls result in unintended parenting to various entities.