make RefreshOverlay default to the player session #32354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
SlamBamActionman
added
the
S: Untriaged
eoineoineoin
added
T: Bugfix
metalgearsloth
added
S: Awaiting Changes
github-actions
bot
added
size/S
beck-thompson
approved these changes
Jan 30, 2025
beck-thompson
added
the
S: Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Changes the EquipmentHudSystem.cs default to the player instead of exiting.
makes it actually good, made the event a struct raised by ref, relayed by ref, etc etc, something something coding conventions
Why / Balance
Bug fix. If you remove the component from a HUD that's being actively worn by a player, it doesn't actually update the overlay. Even worse, it only updates once you put on another item with an overlay, not on unequip.
Technical details
if player exists, set the uid, else return
previously would check if the uid matches the player or else return
Requirements
Breaking changes
none
Changelog
no fun