Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes some mobs not being able to honk/weh #33777

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Fixes some mobs not being able to honk/weh #33777

merged 3 commits into from
Jan 20, 2025

Conversation

ArtisticRoomba
Copy link
Contributor

@ArtisticRoomba ArtisticRoomba commented Dec 8, 2024 •
edited
Loading

About the PR

Some mobs can now honk or weh if forced to by reagents.

Vox can now Honk and Weh.
Arachnids can now Honk.
Moths can now Honk.

Keep in mind that they obviously can't do these emotes by default. It's a prohibited emote that is only allowed if a reagent forces them to (like Juice that makes you Weh or Honk).

Why / Balance

They were missing relevant sounds in the emote sounds YML. Previously, they were unable to honk or weh if forced to by a reagent. They would play the emote, but not the sound.

This change makes it so that they can!

Technical details

A few YML changes in speech_emote_sounds.yml

Media

Content Client_uvObiPLDNQ

Requirements

Changelog
🆑

  • fix: Voxes can now honk, weh, and hew if forced to by a reagent.
  • fix: Arachnids and Moths can now honk if forced to by a reagent.

@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. and removed size/S Denotes a PR that changes 10-99 lines. labels Dec 8, 2024
@beck-thompson beck-thompson added T: Bugfix Type: Bugs and/or bugfixes P3: Standard Priority: Default priority for repository items. D3: Low Difficulty: Some codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Character/Species Area: Player characters and species features and content. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Dec 8, 2024
Aeshus
Aeshus approved these changes Dec 8, 2024
View reviewed changes
Copy link
Contributor

@Aeshus Aeshus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though minor nitpick is that the order that you put Honk and Weh seems to be for them...

Also, who doesn't like style changes in another part of the same file :)

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Dec 18, 2024
@ArtisticRoomba
Merge branch 'master' into various-emote-fixes
2b18fb2 
# Conflicts:
#	Resources/Prototypes/Voice/speech_emote_sounds.yml
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 18, 2024
@ArtisticRoomba
Copy link
Contributor Author

conflicts cleared

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Dec 18, 2024
ScarKy0
ScarKy0 requested changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@ScarKy0 ScarKy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is almost good, just one missing detail.

Resources/Prototypes/Voice/speech_emote_sounds.yml Show resolved Hide resolved
@ScarKy0 ScarKy0 self-assigned this Jan 20, 2025
@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Jan 20, 2025
ScarKy0
ScarKy0 approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@ScarKy0 ScarKy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hew!
Looks all good and tested in game! Thank you for your contribution!

@ScarKy0
Copy link
Contributor

ScarKy0 commented Jan 20, 2025

Staring at the test in progress, waiting...

@ArtisticRoomba
Copy link
Contributor Author

running tests on my machine right now because I know this is going to heisentest

@ScarKy0 ScarKy0 merged commit ed44f32 into space-wizards:master Jan 20, 2025
13 checks passed
@ArtisticRoomba ArtisticRoomba deleted the various-emote-fixes branch January 20, 2025 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScarKy0 ScarKy0 ScarKy0 approved these changes

@Aeshus Aeshus Aeshus approved these changes

Assignees

@ScarKy0 ScarKy0

Labels
A: Character/Species Area: Player characters and species features and content. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ArtisticRoomba @ScarKy0 @Aeshus @beck-thompson