Add history tab to bounty console

[BarryNorfolk]

About the PR

Added a history tab to the cargo bounty console.

Why / Balance

Knowing whether or not any bounties have been completed and when is important for people in charge of logistics, or command for that matter. It's also important to know who skipped what bounties so people can either teach which ones to not skip, or nod sagely at their good skip choices.

Technical details

New to the codebase and C# in general, but seemed somewhat straightforward to add.

Media

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

🆑

• add: Added a history tab to the bounty computer, showing all past completed and skipped orders (and who skipped them).

[lzk228]

a suggestion
why to write the status two times?
small photoshop image how it would look little cleaner
(or if you afraid that a long name will cover the manifest, you can leave the id where it is and place the name in bottom right corner)

[lzk228]

also a question, how it would look if there are two or more items in the manifest

[BarryNorfolk]

a suggestion why to write the status two times?

Felt fine to do so, one is an "At a glance" piece of coloured text so you can see whether something was completed or not. The other is more time based information. I don't really have any opinion about the duplication further than that.

also a question, how it would look if there are two or more items in the manifest.

I'll double check, so far it's just whatever the original bounty manifest would have in it. If that looks crap then I'll refine it further.

[Aeshus]

Thanks for the PR (and congrats on the first contribution)!

I just have mainly stylistic comments, though most of them are inherited from the questionable Cargo Bounty code (so it's not really your fault for not knowing).

Overall, very good PR.

[BarryNorfolk]

Thanks for the PR (and congrats on the first contribution)!

I just have mainly stylistic comments, though most of them are inherited from the questionable Cargo Bounty code (so it's not really your fault for not knowing).

Overall, very good PR.

Cheers, I'll go over these at get them in as a new fix. I merged a version of this to a downstream so I'll add more commits on top so it's easier to bring the two together when they're done!

Any suggestions on formatters btw, the import ordering feels like it should be done via some formatting tool :D

[Aeshus]

Any suggestions on formatters btw, the import ordering feels like it should be done via some formatting tool :D

We primarily use JetBrains Rider (free to use for non commercial projects) for writing code and formatting, though Visual Studio also supports sorting imports and probably everything else we use in Rider.

There’s also a Rider Code Cleanup CLI tool, which should match the normal Rider formatting while being completely free, though I haven’t personally heard of anyone using it yet (could be potentially integrated with VSC if enough work is put into it).

[BarryNorfolk]

Reworked it some more and updated the screenshots in the description. Think I've hit pretty much all your points that you've raised, so let me know. Tons more commits so I can just cherry pick them over to the downstream later on :)

[Aeshus]

Thanks for making the changes I requested!

I like the styling of the cargo bounty entry, though I just had some minor changes that you can make to the code that doesn't affect the way it looks.

Also, what are your thoughts on reversing the order of the history so that it displays the most revent events highest?

The rest are just code style things.

Thanks!

[BarryNorfolk]

Merry crimbus

[Aeshus]

This PR is definitely to the point of being complete!

I have some last comments about some redundant code/documentation stuff, but those aren't the end of the world.

Thanks for going through the whole review process!

[BarryNorfolk]

No worries, the first PR is always the hardest as you have to get used to things. Plus C# is very new to me, so is the codebase. Copy and pasting things only works so well, if the code you're copying is correct ;)
I do plan on doing some more in this area so I can come back later and fix up any documentations and what not.

[beck-thompson]

Looks good to me! Fun idea love the pr 👍