Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blueprint double emergency tank #34232

Merged

Conversation

Nimfar11
Copy link
Contributor

@Nimfar11 Nimfar11 commented Jan 5, 2025

About the PR

Adds Blueprint double emergency oxygen and nitrogen tanks as a rare find for salvagers.

Why / Balance

Slightly more of interest to cargos, as a useful find to expand their abilities. Could be useful as a substitute for conventional tanks.

Media

изображение

Requirements

🆑

  • add: Adds Blueprint double emergency tank.

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. size/S Denotes a PR that changes 10-99 lines. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 5, 2025
@NoElkaTheGod
Copy link
Contributor

NoElkaTheGod commented Jan 5, 2025

Wait, they weren't researchable all this time?

Edit: also would be nice if you added double nitrogen tanks as well.

@Nimfar11
Copy link
Contributor Author

Nimfar11 commented Jan 5, 2025

Edit: also would be nice if you added double nitrogen tanks as well.

It's just an empty tank, does it make sense to make another one in red colour only?

@NoElkaTheGod
Copy link
Contributor

It's just an empty tank, does it make sense to make another one in red colour only?

It's nice to be able to tell at a glance if you'd be able to breathe from a tank or not. Also, i'm pretty sure you can add multiple recipes to one blueprint, so you don't have to make two separate ones.

@deltanedas
Copy link
Contributor

you cant breathe from an empty tank, theres nothing stopping you from filling a yellow one with plasma instead of oxygen either

Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more stuff salvage can find should be good 👍

@slarticodefast slarticodefast self-assigned this Jan 5, 2025
@slarticodefast slarticodefast added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Jan 5, 2025
@NoElkaTheGod
Copy link
Contributor

you cant breathe from an empty tank, theres nothing stopping you from filling a yellow one with plasma instead of oxygen either

If i were to fill oxygen tank with nitrogen, no vox or slime would ever take it, unless i specificaly tell them that it's nitrogen. If having two recipes for two different colors is a problem, why do we even have tanks with different colors in the first place?

@Boaz1111 Boaz1111 added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: Cargo/Salvage Area: Cargo department or Salvage. labels Jan 5, 2025
@ArtisticRoomba
Copy link
Contributor

you cant breathe from an empty tank, theres nothing stopping you from filling a yellow one with plasma instead of oxygen either

If i were to fill oxygen tank with nitrogen, no vox or slime would ever take it, unless i specificaly tell them that it's nitrogen. If having two recipes for two different colors is a problem, why do we even have tanks with different colors in the first place?

to designate roundstart fills

also filling an oxygen tank with nitrogen/plasma is Extremely Funny:tm: and a great way to prank your friend if you're an antag

@Callmore
Copy link
Contributor

Callmore commented Jan 6, 2025

I'm confused on why colour is a concern
you can already print air tanks at an autolathe, they're white and default to 101.03 kpa (or whatever standard pressure is), and aren't blue or red
why does it matter that the tanks are yellow

@Nimfar11
Copy link
Contributor Author

Nimfar11 commented Jan 6, 2025

This kind of tank is printed for personal use. The player will always know what is in there, because he will pump it in himself. At the very least he can label the can. I thought it was unnecessary to make a new tank. But I can add a red one for convenience.
Let me know if it makes sense and is needed.

@NoElkaTheGod
Copy link
Contributor

I dunno, double nitrogen tank already exists, and you can put several recipes on a blueprint, so why not include it there? It's kinda weird that you can craft a yellow tank, but not the red one.

@Boaz1111 Boaz1111 self-assigned this Jan 18, 2025
Copy link
Contributor

@Boaz1111 Boaz1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good! Thanks for the pr!

@Boaz1111 Boaz1111 merged commit 0da6a99 into space-wizards:master Jan 21, 2025
12 checks passed
@Nimfar11 Nimfar11 deleted the double-emergency-tank-blueprint branch January 21, 2025 19:57
widgetbeck pushed a commit to widgetbeck/imp-station-14 that referenced this pull request Jan 29, 2025
* blueprint

* NitrogenTank

* description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Cargo/Salvage Area: Cargo department or Salvage. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/S Denotes a PR that changes 10-99 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants