Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple categories for lathe recipes #34315

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Multiple categories for lathe recipes #34315

wants to merge 8 commits into from

Conversation

iaada
Copy link

@iaada iaada commented Jan 9, 2025 •
edited
Loading

About the PR

This PR lets latheRecipe have multiple categories for filtering.

Why / Balance

It's not hard for an item to have several distinct qualities that you might want to filter for. Used as part of later PRs to add categories to recipes missing them.

Technical details

Changes to a prototype and lathe UI code. yml changes to rename the variable, no functional changes.

Media

Requirements

Breaking changes

LatheRecipePrototype.Category renamed to LatheRecipePrototype.Categories, and is now a list. Custom lathe recipes may need to be updated.

Changelog

nope

@github-actions github-actions bot added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Jan 9, 2025
@iaada iaada mentioned this pull request Jan 9, 2025
Open
2 tasks
@github-actions github-actions bot added the Changes: UI Changes: Might require knowledge of UI design or code. label Jan 9, 2025
@lzk228 lzk228 added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content D3: Low Difficulty: Some codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 9, 2025
@github-actions github-actions bot added the size/M Denotes a PR that changes 100-999 lines. label Jan 9, 2025
@iaada iaada mentioned this pull request Jan 9, 2025
Open
2 tasks
slarticodefast
slarticodefast requested changes Jan 15, 2025
View reviewed changes
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be adjusted for #34034

Content.Shared/Research/Prototypes/LatheRecipePrototype.cs Outdated Show resolved Hide resolved
Content.Client/Lathe/UI/LatheMenu.xaml.cs Outdated Show resolved Hide resolved
@slarticodefast slarticodefast self-assigned this Jan 15, 2025
@slarticodefast slarticodefast added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted labels Jan 15, 2025
@iaada iaada requested a review from slarticodefast January 19, 2025 21:45
@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slarticodefast slarticodefast Awaiting requested review from slarticodefast

Requested changes must be addressed to merge this pull request.

Assignees

@slarticodefast slarticodefast

Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. Changes: UI Changes: Might require knowledge of UI design or code. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iaada @slarticodefast @lzk228